scsi: ufs: fix static checker errors in ufshcd_system_suspend
authorDolev Raviv <draviv@codeaurora.org>
Thu, 23 Oct 2014 10:25:14 +0000 (13:25 +0300)
committerChristoph Hellwig <hch@lst.de>
Thu, 20 Nov 2014 16:47:41 +0000 (17:47 +0100)
This patch fixes newly introduced sparse warning in
ufshcd_system_suspend, introduced by UFS power management series.

Sparse warning:
drivers/scsi/ufs/ufshcd.c:5118 ufshcd_system_suspend()
error: we previously assumed 'hba' could be null (see line 5089)

To fix it, we return 0 in case HBA is not initialized or is
not powered.

Signed-off-by: Dolev Raviv <draviv@codeaurora.org>
Reviewed-by: Maya Erez <merez@codeaurora.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/ufs/ufshcd.c

index 77a4e38..d3f6ddb 100644 (file)
@@ -5104,7 +5104,7 @@ int ufshcd_system_suspend(struct ufs_hba *hba)
        int ret = 0;
 
        if (!hba || !hba->is_powered)
-               goto out;
+               return 0;
 
        if (pm_runtime_suspended(hba->dev)) {
                if (hba->rpm_lvl == hba->spm_lvl)