Staging: iio: ad7150: constify attribute_group structures
authorBhumika Goyal <bhumirks@gmail.com>
Sat, 1 Oct 2016 19:15:15 +0000 (00:45 +0530)
committerJonathan Cameron <jic23@kernel.org>
Mon, 3 Oct 2016 20:08:09 +0000 (21:08 +0100)
Check for attribute_group structures that are only stored in the
event_attrs filed of iio_info structure. As the event_attrs field
of iio_info structures is constant, so these attribute_group
structures can also be declared constant.
Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
struct iio_info x;
@@
x.event_attrs=&i@p;

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before:
   text    data     bss     dec     hex filename
   3561    1152       8    4721    1271 drivers/staging/iio/cdc/ad7150.o

File size after:
   text    data     bss     dec     hex filename
   3625    1088       8    4721    1271 drivers/staging/iio/cdc/ad7150.o

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/staging/iio/cdc/ad7150.c

index 5578a07..6998c3d 100644 (file)
@@ -562,7 +562,7 @@ static struct attribute *ad7150_event_attributes[] = {
        NULL,
 };
 
-static struct attribute_group ad7150_event_attribute_group = {
+static const struct attribute_group ad7150_event_attribute_group = {
        .attrs = ad7150_event_attributes,
        .name = "events",
 };