pinctrl: single: fix a never true comparison
authorDario Binacchi <dariobin@libero.it>
Thu, 22 Apr 2021 20:28:56 +0000 (22:28 +0200)
committerTom Rini <trini@konsulko.com>
Tue, 27 Apr 2021 12:05:30 +0000 (08:05 -0400)
As reported by Coverity Scan for Das U-Boot, the 'less-than-zero'
comparison of an unsigned value is never true.

Signed-off-by: Dario Binacchi <dariobin@libero.it>
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
drivers/pinctrl/pinctrl-single.c

index 17f3818..ebb7602 100644 (file)
@@ -295,7 +295,7 @@ static int single_configure_pins(struct udevice *dev,
        func->npins = 0;
        for (n = 0; n < count; n++, pins++) {
                offset = fdt32_to_cpu(pins->reg);
-               if (offset < 0 || offset > pdata->offset) {
+               if (offset > pdata->offset) {
                        dev_err(dev, "  invalid register offset 0x%x\n",
                                offset);
                        continue;
@@ -348,7 +348,7 @@ static int single_configure_bits(struct udevice *dev,
        func->npins = 0;
        for (n = 0; n < count; n++, pins++) {
                offset = fdt32_to_cpu(pins->reg);
-               if (offset < 0 || offset > pdata->offset) {
+               if (offset > pdata->offset) {
                        dev_dbg(dev, "  invalid register offset 0x%x\n",
                                offset);
                        continue;