perf test: Make the rdpmc test honour 'verbose' mode
authorArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 26 Apr 2012 19:22:09 +0000 (16:22 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 2 May 2012 18:14:12 +0000 (15:14 -0300)
It was unconditionally printing debug stuff when in non -v mode we
should just print the name and result of the test.

Now:

[root@sandy ~]# perf test rdpmc
 6: x86 rdpmc test: Ok
[root@sandy ~]# perf test -v rdpmc
 6: x86 rdpmc test:
--- start ---
             0:           6030
             1:          60030
             2:         600050
             3:        6000056
             4:       60000070
             5:      600000266
   ---- end ----
x86 rdpmc test: Ok
[root@sandy ~]#

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-0tjedaozsy9oarq30nvzg74b@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-test.c

index 1c5b980..5502a4a 100644 (file)
@@ -1549,8 +1549,6 @@ static int __test__rdpmc(void)
        sa.sa_sigaction = segfault_handler;
        sigaction(SIGSEGV, &sa, NULL);
 
-       fprintf(stderr, "\n\n");
-
        fd = sys_perf_event_open(&attr, 0, -1, -1, 0);
        if (fd < 0) {
                die("Error: sys_perf_event_open() syscall returned "
@@ -1575,7 +1573,7 @@ static int __test__rdpmc(void)
                loops *= 10;
 
                delta = now - stamp;
-               fprintf(stderr, "%14d: %14Lu\n", n, (long long)delta);
+               pr_debug("%14d: %14Lu\n", n, (long long)delta);
 
                delta_sum += delta;
        }
@@ -1583,7 +1581,7 @@ static int __test__rdpmc(void)
        munmap(addr, page_size);
        close(fd);
 
-       fprintf(stderr, "   ");
+       pr_debug("   ");
 
        if (!delta_sum)
                return -1;