ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler
authorGuangqing Zhu <zhuguangqing83@gmail.com>
Thu, 15 Apr 2021 07:38:29 +0000 (15:38 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 15 Apr 2021 15:07:54 +0000 (16:07 +0100)
Coccinelle noticed:
  sound/soc/codecs/wcd934x.c:5041:7-32: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT

Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210415073829.22750-1-zhuguangqing83@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wcd934x.c

index 5fe4033..cddc49b 100644 (file)
@@ -5040,7 +5040,7 @@ static int wcd934x_codec_probe(struct platform_device *pdev)
 
        ret = devm_request_threaded_irq(dev, irq, NULL,
                                        wcd934x_slim_irq_handler,
-                                       IRQF_TRIGGER_RISING,
+                                       IRQF_TRIGGER_RISING | IRQF_ONESHOT,
                                        "slim", wcd);
        if (ret) {
                dev_err(dev, "Failed to request slimbus irq\n");