devlink: fix incorrect return statement
authorArnd Bergmann <arnd@arndb.de>
Fri, 6 Jul 2018 12:58:51 +0000 (14:58 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Jul 2018 11:06:42 +0000 (20:06 +0900)
A newly added dummy helper function tries to return a failure from a "void"
function:

In file included from include/net/dsa.h:24,
                 from arch/arm/plat-orion/common.c:21:
include/net/devlink.h: In function 'devlink_param_value_changed':
include/net/devlink.h:771:9: error: 'return' with a value, in function returning void [-Werror]
  return -EOPNOTSUPP;

This fixes it by removing the bogus statement.

Fixes: ea601e170988 ("devlink: Add devlink notifications support for params")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/devlink.h

index 8ed5713..f67c29c 100644 (file)
@@ -768,7 +768,6 @@ devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id,
 static inline void
 devlink_param_value_changed(struct devlink *devlink, u32 param_id)
 {
-       return -EOPNOTSUPP;
 }
 
 #endif