scsi: dc395x: Open-code status_byte(u8) calls
authorBart Van Assche <bvanassche@acm.org>
Thu, 15 Apr 2021 22:08:21 +0000 (15:08 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 16 Apr 2021 02:44:41 +0000 (22:44 -0400)
The dc395x driver is one of the two drivers that passes an u8 argument to
status_byte() instead of an s32 argument. Open-code status_byte() in
preparation of changing SCSI status values into a structure.

Link: https://lore.kernel.org/r/20210415220826.29438-16-bvanassche@acm.org
Cc: Hannes Reinecke <hare@suse.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/dc395x.c

index 1e9ec4d..be87d5a 100644 (file)
@@ -3258,10 +3258,10 @@ static void srb_done(struct AdapterCtlBlk *acb, struct DeviceCtlBlk *dcb,
                /*
                 * target status..........................
                 */
-               if (status_byte(status) == CHECK_CONDITION) {
+               if (status >> 1 == CHECK_CONDITION) {
                        request_sense(acb, dcb, srb);
                        return;
-               } else if (status_byte(status) == QUEUE_FULL) {
+               } else if (status >> 1 == QUEUE_FULL) {
                        tempcnt = (u8)list_size(&dcb->srb_going_list);
                        dprintkl(KERN_INFO, "QUEUE_FULL for dev <%02i-%i> with %i cmnds\n",
                             dcb->target_id, dcb->target_lun, tempcnt);