sched: Optimize build_sched_domains() for saving first SD node for a cpu
authorViresh Kumar <viresh.kumar@linaro.org>
Tue, 4 Jun 2013 10:11:15 +0000 (15:41 +0530)
committerIngo Molnar <mingo@kernel.org>
Wed, 19 Jun 2013 10:58:43 +0000 (12:58 +0200)
We are saving first scheduling domain for a cpu in build_sched_domains() by
iterating over the nested sd->child list. We don't actually need to do it this
way.

tl will be equal to sched_domain_topology for the first iteration and so we can
set *per_cpu_ptr(d.sd, i) based on that.  So, save pointer to first SD while
running the iteration loop over tl's.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/fc473527cbc4dfa0b8eeef2a59db74684eb59a83.1370436120.git.viresh.kumar@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/core.c

index 342e744..137dcc0 100644 (file)
@@ -5985,16 +5985,13 @@ static int build_sched_domains(const struct cpumask *cpu_map,
                sd = NULL;
                for (tl = sched_domain_topology; tl->init; tl++) {
                        sd = build_sched_domain(tl, cpu_map, attr, sd, i);
+                       if (tl == sched_domain_topology)
+                               *per_cpu_ptr(d.sd, i) = sd;
                        if (tl->flags & SDTL_OVERLAP || sched_feat(FORCE_SD_OVERLAP))
                                sd->flags |= SD_OVERLAP;
                        if (cpumask_equal(cpu_map, sched_domain_span(sd)))
                                break;
                }
-
-               while (sd->child)
-                       sd = sd->child;
-
-               *per_cpu_ptr(d.sd, i) = sd;
        }
 
        /* Build the groups for the domains */