mfd: arizona: Only attempt to parse DT if platform data was not passed
authorLee Jones <lee.jones@linaro.org>
Fri, 27 Sep 2013 13:25:55 +0000 (14:25 +0100)
committerLee Jones <lee.jones@linaro.org>
Wed, 23 Oct 2013 15:21:41 +0000 (16:21 +0100)
If platform data is passed when probing the device then it should take
precedence over Device Tree. This patch saves cycles in the pdata case
and prevents error messages when DT is not passed.

Reported-by: Mark Brown <broonie@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/arizona-core.c

index 5ac3aa4..a2f5bef 100644 (file)
@@ -607,11 +607,11 @@ int arizona_dev_init(struct arizona *arizona)
        dev_set_drvdata(arizona->dev, arizona);
        mutex_init(&arizona->clk_lock);
 
-       arizona_of_get_core_pdata(arizona);
-
        if (dev_get_platdata(arizona->dev))
                memcpy(&arizona->pdata, dev_get_platdata(arizona->dev),
                       sizeof(arizona->pdata));
+       else
+               arizona_of_get_core_pdata(arizona);
 
        regcache_cache_only(arizona->regmap, true);