Imported Upstream version 5.1.9 into tizen

Change-Id: I68f6b51063d39f2c94cd9e42968033dc60f2508d

diff --combined gif2rgb.c
index 051c5a2,415ffed..0269234
--- 1/util/gif2rgb.c
--- 2/gif2rgb.c
+++ b/gif2rgb.c
@@@ -36,9 -36,8 +36,9 @@@ with our utilities mainly interesting a
  
  #define PROGRAM_NAME  "gif2rgb"
  
 +__attribute__((__section__(".tizen.build-id")))
  static char
 -    *VersionStr =
 +    VersionStr[] =
        PROGRAM_NAME
        VERSION_COOKIE
        "       Gershon Elber,  "
@@@ -96,7 -95,6 +96,6 @@@ static void LoadRGB(char *FileName
  
            for (i = 0; i < 3; i++) {
                strncpy(OneFileName, FileName, sizeof(OneFileName)-1);
-               /* cppcheck-suppress uninitstring */
                strncat(OneFileName, Postfixes[i], 
                        sizeof(OneFileName) - 1 - strlen(OneFileName));
  
@@@ -151,9 -149,7 +150,7 @@@
        }
  
        fclose(rgbfp[0]);
-       // cppcheck-suppress useClosedFile
        fclose(rgbfp[1]);
-       // cppcheck-suppress useClosedFile
        fclose(rgbfp[2]);
      }
  }
@@@ -179,13 -175,10 +176,10 @@@ static void SaveGif(GifByteType *Output
                          Width, Height, ExpColorMapSize, 0,
                          OutputColorMap) == GIF_ERROR ||
        EGifPutImageDesc(GifFile,
-                        0, 0, Width, Height, false, NULL) ==
-                                                                    GIF_ERROR)
+                        0, 0, Width, Height, false, NULL) == GIF_ERROR) {
        PrintGifError(Error);
-       if (GifFile != NULL) {
-           EGifCloseFile(GifFile, NULL);
-       }
        exit(EXIT_FAILURE);
+     }
  
      GifQprintf("\n%s: Image 1 at (%d, %d) [%dx%d]:     ",
               PROGRAM_NAME, GifFile->Image.Left, GifFile->Image.Top,
@@@ -193,23 -186,16 +187,16 @@@
  
      for (i = 0; i < Height; i++) {
        if (EGifPutLine(GifFile, Ptr, Width) == GIF_ERROR)
-       {
-           if (GifFile != NULL) {
-               EGifCloseFile(GifFile, NULL);
-           }
            exit(EXIT_FAILURE);
-       }
        GifQprintf("\b\b\b\b%-4d", Height - i - 1);
  
        Ptr += Width;
      }
  
-     if (EGifCloseFile(GifFile, &Error) == GIF_ERROR)
+     if (EGifCloseFile(GifFile, &Error) == GIF_ERROR) {
        PrintGifError(Error);
-       if (GifFile != NULL) {
-           EGifCloseFile(GifFile, NULL);
-       }
        exit(EXIT_FAILURE);
+     }
  }
  
  /******************************************************************************
@@@ -274,7 -260,6 +261,6 @@@ static void DumpScreen2RGB(char *FileNa
  
              for (i = 0; i < 3; i++) {
                  strncpy(OneFileName, FileName, sizeof(OneFileName)-1);
-               /* cppcheck-suppress uninitstring */
                  strncat(OneFileName, Postfixes[i], 
                        sizeof(OneFileName) - 1 - strlen(OneFileName));
      
@@@ -293,6 -278,11 +279,11 @@@
          rgbfp[0] = stdout;
      }
  
+     if (ColorMap == NULL) {
+       fprintf(stderr, "Color map pointer is NULL.\n");
+       exit(EXIT_FAILURE);
+     }
+ 
      if (OneFileFlag) {
          unsigned char *Buffer, *BufferP;
  
@@@ -340,9 -330,7 +331,7 @@@
          free((char *) Buffers[1]);
          free((char *) Buffers[2]);
          fclose(rgbfp[0]);
-       // cppcheck-suppress useClosedFile
          fclose(rgbfp[1]);
-       // cppcheck-suppress useClosedFile
          fclose(rgbfp[2]);
      }
  }
@@@ -379,6 -367,11 +368,11 @@@ static void GIF2RGB(int NumFiles, char 
        }
      }
  
+     if (GifFile->SHeight == 0 || GifFile->SWidth == 0) {
+       fprintf(stderr, "Image of width or height 0\n");
+       exit(EXIT_FAILURE);
+     }
+ 
      /* 
       * Allocate the screen as vector of column of rows. Note this
       * screen is device independent - it's the screen defined by the
@@@ -468,7 -461,7 +462,7 @@@
                break;
        }
      } while (RecordType != TERMINATE_RECORD_TYPE);
- 
+     
      /* Lets dump it - set the global variables required and do it: */
      ColorMap = (GifFile->Image.ColorMap
                ? GifFile->Image.ColorMap

diff --combined gifbg.c
index eb15a50,e909e82..4ab1c14
--- 1/util/gifbg.c
--- 2/gifbg.c
+++ b/gifbg.c
@@@ -39,9 -39,8 +39,9 @@@ gifbg - generate a test-pattern GI
  
  #define DEFAULT_DIR   "T"                        /* TOP (North) direction. */
  
 +__attribute__((__section__(".tizen.build-id")))
  static char
 -    *VersionStr =
 +    VersionStr[] =
        PROGRAM_NAME
        VERSION_COOKIE
        "       Gershon Elber,  "
@@@ -71,7 -70,6 +71,6 @@@ static void QuitGifError(GifFileType *G
  ******************************************************************************/
  int main(int argc, char **argv)
  {
-     unsigned int Ratio;
      int       i, l, LevelWidth, LogNumLevels, ErrorCode, Count = 0;
      bool Error, FlipDir, DoAllMaximum = false,
        DirectionFlag = false, LevelsFlag = false, ColorFlag = false,
@@@ -160,7 -158,7 +159,7 @@@
            break;
      }
      if (Direction == DIR_NONE)
-       GIF_EXIT("Direction requested (-d option) is wierd!");
+       GIF_EXIT("Direction requested (-d option) is weird!");
  
      /* We are going to handle only TOP, TOP_RIGHT, RIGHT, BOT_RIGHT  so flip */
      /* the complement cases (TOP <-> BOT for example) by flipping the      */
@@@ -210,9 -208,9 +209,9 @@@
  
      for (i = 1; i <= NumLevels; i++) {
        /* Ratio will be in the range of 0..100 for required intensity: */
-       Ratio = (MaximumIntensity * (i * (256 / NumLevels)) +
-                MinimumIntensity * ((NumLevels - i) * (256 / NumLevels))) /
-                256;
+       unsigned int Ratio = (MaximumIntensity * (i * (256 / NumLevels)) +
+                             MinimumIntensity * ((NumLevels - i) * (256 / NumLevels))) /
+           256;
        ColorMap->Colors[i-1].Red   = (RedColor * Ratio) / 100;
        ColorMap->Colors[i-1].Green = (GreenColor * Ratio) / 100;
        ColorMap->Colors[i-1].Blue  = (BlueColor * Ratio) / 100;
@@@ -328,9 -326,6 +327,6 @@@
      if (EGifCloseFile(GifFile, &ErrorCode) == GIF_ERROR)
      {
        PrintGifError(ErrorCode);
-       if (GifFile != NULL) {
-           EGifCloseFile(GifFile, NULL);
-       }
        exit(EXIT_FAILURE);
      }
  

diff --combined gifbuild.c
index 70fea58,7076830..654010d
--- 1/util/gifbuild.c
--- 2/gifbuild.c
+++ b/gifbuild.c
@@@ -16,9 -16,8 +16,9 @@@ gifbuild - dump GIF data in a textual f
  
  #define PROGRAM_NAME  "gifbuild"
  
 +__attribute__((__section__(".tizen.build-id")))
  static char
 -    *VersionStr =
 +    VersionStr[] =
        PROGRAM_NAME
        VERSION_COOKIE
        "       Eric Raymond,   "
@@@ -171,15 -170,12 +171,12 @@@ static void Icon2Gif(char *FileName, FI
         * Explicit header declarations
         */
  
-       // cppcheck-suppress invalidscanf 
        if (sscanf(buf, "screen width %d\n", &GifFileOut->SWidth) == 1)
            continue;
  
-       // cppcheck-suppress invalidscanf 
        else if (sscanf(buf, "screen height %d\n", &GifFileOut->SHeight) == 1)
            continue;
  
-       // cppcheck-suppress invalidscanf 
        else if (sscanf(buf, "screen colors %d\n", &n) == 1)
        {
            int ResBits = GifBitSize(n);
@@@ -194,13 -190,11 +191,11 @@@
            continue;
        }
  
-       // cppcheck-suppress invalidscanf 
        else if (sscanf(buf,
                        "screen background %d\n",
                        &GifFileOut->SBackGroundColor) == 1)
            continue;
  
-       // cppcheck-suppress invalidscanf 
        else if (sscanf(buf, "pixel aspect byte %u\n", &intval) == 1) {
            GifFileOut->AspectByte = (GifByteType)(intval & 0xff);
            continue;
@@@ -239,7 -233,6 +234,6 @@@
            memset(LocalColorKeys, '\0', sizeof(LocalColorKeys));
        }
  
-       // cppcheck-suppress invalidscanf 
        else if (sscanf(buf, "  rgb %d %d %d is %c",
                   &red, &green, &blue, &KeyTable[ColorMapSize]) == 4)
        {
@@@ -249,7 -242,6 +243,6 @@@
            ColorMapSize++;
        }
  
-       // cppcheck-suppress invalidscanf 
        else if (sscanf(buf, "  rgb %d %d %d", &red, &green, &blue) == 3)
        {
            ColorMap[ColorMapSize].Red = red;
@@@ -284,15 -276,15 +277,15 @@@
        }
  
        /* GIF inclusion */
-       // cppcheck-suppress invalidscanf 
-       else if (sscanf(buf, "include %s", InclusionFile) == 1)
+       /* ugly magic number is because scanf has no */
+       else if (sscanf(buf, "include %63s", InclusionFile) == 1)
        {
            int         ErrorCode;
            bool        DoTranslation;
            GifPixelType        Translation[256];
  
            GifFileType *Inclusion;
-           SavedImage  *NewImage, *CopyFrom;
+           SavedImage  *CopyFrom;
  
            if ((Inclusion = DGifOpenFileName(InclusionFile, &ErrorCode)) == NULL) {
                PrintGifError(ErrorCode);
@@@ -312,16 -304,18 +305,18 @@@
                exit(EXIT_FAILURE);
            }
  
+           //cppcheck-suppress nullPointerRedundantCheck
            if ((DoTranslation = (GifFileOut->SColorMap!=(ColorMapObject*)NULL)))
            {
                ColorMapObject  *UnionMap;
  
-               UnionMap = GifUnionColorMap(GifFileOut->SColorMap,
-                                        Inclusion->SColorMap, Translation);
+               //cppcheck-suppress nullPointerRedundantCheck
+               UnionMap = GifUnionColorMap(GifFileOut->SColorMap, Inclusion->SColorMap, Translation);
  
                if (UnionMap == NULL)
                {
                    PARSE_ERROR("Inclusion failed --- global map conflict.");
+                   //cppcheck-suppress nullPointerRedundantCheck
                    PrintGifError(GifFileOut->Error);
                    if (Inclusion != NULL) DGifCloseFile(Inclusion, NULL);
                    if (GifFileOut != NULL) EGifCloseFile(GifFileOut, NULL);
@@@ -332,13 -326,17 +327,17 @@@
                GifFileOut->SColorMap = UnionMap;
            }
  
+           //cppcheck-suppress nullPointerRedundantCheck
            for (CopyFrom = Inclusion->SavedImages;
+                //cppcheck-suppress nullPointerRedundantCheck
                 CopyFrom < Inclusion->SavedImages + Inclusion->ImageCount;
                 CopyFrom++)
            {
+               SavedImage      *NewImage;
                if ((NewImage = GifMakeSavedImage(GifFileOut, CopyFrom)) == NULL)
                {
                    PARSE_ERROR("Inclusion failed --- out of memory.");
+                   //cppcheck-suppress nullPointerRedundantCheck
                    PrintGifError(GifFileOut->Error);
                    if (Inclusion != NULL) DGifCloseFile(Inclusion, NULL);
                    if (GifFileOut != NULL) EGifCloseFile(GifFileOut, NULL);
@@@ -421,7 -419,6 +420,6 @@@
  
                    while (isspace(*tp))
                        tp++;
-                   // cppcheck-suppress invalidscanf 
                    if (sscanf(tp, "disposal mode %d\n", &gcb.DisposalMode))
                        continue;
                    if (strcmp(tp, "user input flag on\n") == 0) {
@@@ -432,10 -429,8 +430,8 @@@
                        gcb.UserInputFlag = false;
                        continue;
                    }
-                   // cppcheck-suppress invalidscanf 
                    if (sscanf(tp, "delay %d\n", &gcb.DelayTime))
                        continue;
-                   // cppcheck-suppress invalidscanf 
                    if (sscanf(tp, "transparent index %d\n",
                               &gcb.TransparentColor))
                        continue;
@@@ -454,7 -449,6 +450,6 @@@
            }
  
        }
-       // cppcheck-suppress invalidscanf 
        else if (sscanf(buf, "netscape loop %u", &intval))
        {
            unsigned char params[3] = {1, 0, 0};
@@@ -477,7 -471,6 +472,6 @@@
            }
            
        }
-       // cppcheck-suppress invalidscanf 
        else if (sscanf(buf, "extension %x", &ExtCode))
        {
            int bc = 0;
@@@ -538,11 -531,9 +532,9 @@@
        /*
         * Accept image attributes
         */
-       // cppcheck-suppress invalidscanf 
        else if (sscanf(buf, "image top %d\n", &NewImage->ImageDesc.Top) == 1)
            continue;
  
-       // cppcheck-suppress invalidscanf 
        else if (sscanf(buf, "image left %d\n", &NewImage->ImageDesc.Left)== 1)
            continue;
  
@@@ -552,7 -543,6 +544,6 @@@
            continue;
        }
  
-       // cppcheck-suppress invalidscanf 
        else if (sscanf(buf,
                        "image bits %d by %d",
                        &NewImage->ImageDesc.Width,
@@@ -693,6 -683,7 +684,7 @@@ static void DumpExtensions(GifFileType 
            putchar('\n');
            while (!last && ep[1].Function == CONTINUE_EXT_FUNC_CODE) {
                ++ep;
+               last = (ep - ExtensionBlocks == (ExtensionBlockCount - 1));
                VisibleDumpBuffer(ep->Bytes, ep->ByteCount);
                putchar('\n');
            }
@@@ -704,6 -695,7 +696,7 @@@
            putchar('\n');
            while (!last && ep[1].Function == CONTINUE_EXT_FUNC_CODE) {
                ++ep;
+               last = (ep - ExtensionBlocks == (ExtensionBlockCount - 1));
                VisibleDumpBuffer(ep->Bytes, ep->ByteCount);
                putchar('\n');
            }
@@@ -724,7 -716,10 +717,10 @@@
            printf("\ttransparent index %d\n", gcb.TransparentColor);
            printf("end\n\n");
        }
-       else if (ep->Function == APPLICATION_EXT_FUNC_CODE 
+       else if (!last
+                && ep->Function == APPLICATION_EXT_FUNC_CODE
+                && ep->ByteCount >= 11
+                && (ep+1)->ByteCount >= 3
                 && memcmp(ep->Bytes, "NETSCAPE2.0", 11) == 0) {
            unsigned char *params = (++ep)->Bytes;
            unsigned int loopcount = params[1] | (params[2] << 8);
@@@ -735,6 -730,7 +731,7 @@@
            VisibleDumpBuffer(ep->Bytes, ep->ByteCount);
            while (!last && ep[1].Function == CONTINUE_EXT_FUNC_CODE) {
                ++ep;
+               last = (ep - ExtensionBlocks == (ExtensionBlockCount - 1));
                VisibleDumpBuffer(ep->Bytes, ep->ByteCount);
                putchar('\n');
            }
@@@ -847,7 -843,7 +844,7 @@@ static void Gif2Icon(char *FileName
        for (i = 0; i < image->ImageDesc.Height; i++) {
            for (j = 0; j < image->ImageDesc.Width; j++) {
                GifByteType ch = image->RasterBits[i*image->ImageDesc.Width + j];
-               if (ColorCount < PRINTABLES)
+               if (ColorCount < PRINTABLES && ch < PRINTABLES)
                    putchar(NameTable[ch]);
                else
                    printf("%02x", ch);
@@@ -871,6 -867,17 +868,17 @@@
      if (fdin == -1)
        (void) printf("# End of %s dump\n", FileName);
  
+ 
+     /*
+      * Sanity checks.
+      */
+ 
+     /* check that the background color isn't garbage (SF bug #87) */
+     if (GifFile->SBackGroundColor < 0
+           || GifFile->SBackGroundColor >= GifFile->SColorMap->ColorCount) {
+         fprintf(stderr, "gifbuild: background color invalid for screen colormap.\n");
+     }
+ 
      if (DGifCloseFile(GifFile, &ErrorCode) == GIF_ERROR) {
        PrintGifError(ErrorCode);
        exit(EXIT_FAILURE);

diff --combined gifclrmp.c
index 7d35d7c,7a684a8..cf335f9
--- 1/util/gifclrmp.c
--- 2/gifclrmp.c
+++ b/gifclrmp.c
@@@ -17,9 -17,8 +17,9 @@@ gifclrmap - extract colormaps from GIF 
  
  #define PROGRAM_NAME  "gifclrmp"
  
 +__attribute__((__section__(".tizen.build-id")))
  static char
 -    *VersionStr =
 +    VersionStr[] =
        PROGRAM_NAME
        VERSION_COOKIE
        "       Gershon Elber,  "
@@@ -223,6 -222,8 +223,8 @@@ int main(int argc, char **argv
                /* pass through extension records */
                if (DGifGetExtension(GifFileIn, &ExtCode, &Extension) == GIF_ERROR)
                    QuitGifError(GifFileIn, GifFileOut);
+               if (Extension == NULL)
+                   break;
                if (EGifPutExtensionLeader(GifFileOut, ExtCode) == GIF_ERROR)
                    QuitGifError(GifFileIn, GifFileOut);
                if (EGifPutExtensionBlock(GifFileOut, 

diff --combined gifcolor.c
index b3e586b,f00ad38..a4d97b2
--- 1/util/gifcolor.c
--- 2/gifcolor.c
+++ b/gifcolor.c
@@@ -18,9 -18,8 +18,9 @@@ gifcolor - generate color test-pattern 
  #define LINE_LEN              40
  #define IMAGEWIDTH            LINE_LEN*GIF_FONT_WIDTH
  
 +__attribute__((__section__(".tizen.build-id")))
  static char
 -    *VersionStr =
 +    VersionStr[] =
        PROGRAM_NAME
        VERSION_COOKIE
        "       Gershon Elber,  "
@@@ -135,7 -134,6 +135,6 @@@ int main(int argc, char **argv
  static void GenRasterTextLine(GifRowType *RasterBuffer, char *TextLine,
                                        int BufferWidth, int ForeGroundIndex)
  {
-     unsigned char c;
      unsigned char Byte, Mask;
      int i, j, k, CharPosX, Len = strlen(TextLine);
  
@@@ -143,7 -141,7 +142,7 @@@
          for (j = 0; j < GIF_FONT_HEIGHT; j++) RasterBuffer[j][i] = BackGround;
  
      for (i = CharPosX = 0; i < Len; i++, CharPosX += GIF_FONT_WIDTH) {
-       c = TextLine[i];
+       unsigned char c = TextLine[i];
        for (j = 0; j < GIF_FONT_HEIGHT; j++) {
            Byte = GifAsciiTable8x8[(unsigned short)c][j];
            for (k = 0, Mask = 128; k < GIF_FONT_WIDTH; k++, Mask >>= 1)

diff --combined gifecho.c
index 9b748f8,dc78cb5..e7b20f1
--- 1/util/gifecho.c
--- 2/gifecho.c
+++ b/gifecho.c
@@@ -25,9 -25,8 +25,9 @@@ gifecho - generate a GIF from ASCII tex
  #define DEFAULT_COLOR_GREEN   255
  #define DEFAULT_COLOR_BLUE    255
  
 +__attribute__((__section__(".tizen.build-id")))
  static char
 -    *VersionStr =
 +    VersionStr[] =
        PROGRAM_NAME
        VERSION_COOKIE
        "       Gershon Elber,  "
@@@ -57,7 -56,7 +57,7 @@@ int main(int argc, char **argv
        ForeGroundIndex = DEFAULT_FG_INDEX;
      bool Error, ClrMapSizeFlag = false, ForeGroundFlag = false,
        TextLineFlag = false, HelpFlag = false, ColorFlag = false;
-     char *TextLines[MAX_NUM_TEXT_LINES], Line[LINE_LEN];
+     char *TextLines[MAX_NUM_TEXT_LINES];
      GifRowType RasterBuffer[GIF_FONT_HEIGHT];
      ColorMapObject *ColorMap;
      GifFileType *GifFile;
@@@ -91,6 -90,7 +91,7 @@@
        ImageWidth = GIF_FONT_WIDTH * strlen(TextLines[0]);
      }
      else {
+       char Line[LINE_LEN];
        NumOfLines = l = 0;
        while (fgets(Line, LINE_LEN - 1, stdin)) {
            for (i = strlen(Line); i > 0 && Line[i-1] <= ' '; i--);
@@@ -163,9 -163,6 +164,6 @@@
      if (EGifCloseFile(GifFile, &ErrorCode) == GIF_ERROR)
      {
        PrintGifError(ErrorCode);
-       if (GifFile != NULL) {
-           EGifCloseFile(GifFile, NULL);
-       }
        exit(EXIT_FAILURE);
      }
  
@@@ -178,7 -175,6 +176,6 @@@
  static void GenRasterTextLine(GifRowType *RasterBuffer, char *TextLine,
                                        int BufferWidth, int ForeGroundIndex)
  {
-     unsigned char c;
      unsigned char Byte, Mask;
      int i, j, k, CharPosX, Len = strlen(TextLine);
  
@@@ -186,7 -182,7 +183,7 @@@
          for (j = 0; j < GIF_FONT_HEIGHT; j++) RasterBuffer[j][i] = 0;
  
      for (i = CharPosX = 0; i < Len; i++, CharPosX += GIF_FONT_WIDTH) {
-       c = TextLine[i];
+       unsigned char c = TextLine[i];
        for (j = 0; j < GIF_FONT_HEIGHT; j++) {
            Byte = GifAsciiTable8x8[(unsigned short)c][j];
            for (k = 0, Mask = 128; k < GIF_FONT_WIDTH; k++, Mask >>= 1)

diff --combined giffix.c
index 907c3ef,6764bab..bd6fdeb
--- 1/util/giffix.c
--- 2/giffix.c
+++ b/giffix.c
@@@ -15,9 -15,8 +15,9 @@@ giffix - attempt to fix a truncated GI
  
  #define PROGRAM_NAME  "giffix"
  
 +__attribute__((__section__(".tizen.build-id")))
  static char
 -    *VersionStr =
 +    VersionStr[] =
        PROGRAM_NAME
        VERSION_COOKIE
        "       Gershon Elber,  "
@@@ -202,7 -201,7 +202,7 @@@ int main(int argc, char **argv
  ******************************************************************************/
  static void QuitGifError(GifFileType *GifFileIn, GifFileType *GifFileOut)
  {
-     fprintf(stderr, "\nFollowing unrecoverable error occured:");
+     fprintf(stderr, "\nFollowing unrecoverable error occurred:");
      if (GifFileIn != NULL) {
        PrintGifError(GifFileIn->Error);
        EGifCloseFile(GifFileIn, NULL);

diff --combined gifhisto.c
index e8e695f,2e6bd7b..e8e695f
--- 1/util/gifhisto.c
--- 2/gifhisto.c
+++ b/gifhisto.c
@@@ -19,9 -19,8 +19,9 @@@ gifhisto - make a color histogram from 
  #define DEFAULT_HISTO_HEIGHT  256
  #define HISTO_BITS_PER_PIXEL  2       /* Size of bitmap for histogram GIF. */
  
 +__attribute__((__section__(".tizen.build-id")))
  static char
 -    *VersionStr =
 +    VersionStr[] =
        PROGRAM_NAME
        VERSION_COOKIE
        "       Gershon Elber,  "

diff --combined gifinto.c
index 306c489,2b91714..cda67bc
--- 1/util/gifinto.c
--- 2/gifinto.c
+++ b/gifinto.c
@@@ -4,7 -4,6 +4,6 @@@ gifinto - save GIF on stdin to file if 
  
  *****************************************************************************/
  
- #include <unistd.h>
  #include <fcntl.h>
  #include <stdio.h>
  #include <stdlib.h>
@@@ -14,6 -13,8 +13,8 @@@
  
  #ifdef _WIN32
  #include <io.h>
+ #else
+ #include <unistd.h>
  #endif /* _WIN32 */
  
  #include "gif_lib.h"
@@@ -27,9 -28,8 +28,9 @@@
  #define       DEFAULT_OUT_NAME        "GifInto.Gif"
  #define DEFAULT_TMP_NAME      "TempInto.XXXXXX"
  
 +__attribute__((__section__(".tizen.build-id")))
  static char
 -    *VersionStr =
 +    VersionStr[] =
        PROGRAM_NAME
        VERSION_COOKIE
        "       Gershon Elber,  "
@@@ -74,7 -74,7 +75,7 @@@ int main(int argc, char **argv
      int FD;
      int       NumFiles;
      bool Error, MinSizeFlag = false, HelpFlag = false;
-     char **FileName = NULL, FoutTmpName[STRLEN], FullPath[STRLEN], *p;
+     char **FileName = NULL, FoutTmpName[STRLEN+1], FullPath[STRLEN+1], *p;
      FILE *Fin, *Fout;
  
      if ((Error = GAGetArgs(argc, argv, CtrlStr, &GifNoisyPrint,
@@@ -113,7 -113,6 +114,6 @@@
      if ( *FileName == NULL ) GIF_EXIT("No valid Filename given.");
      if ( strlen(*FileName) > STRLEN-1 ) GIF_EXIT("Filename too long.");
      memset(FullPath, '\0', sizeof(FullPath));
-     // cppcheck-suppress redundantCopy
      strncpy(FullPath, *FileName, STRLEN);
      if ((p = strrchr(FullPath, '/')) != NULL ||
        (p = strrchr(FullPath, '\\')) != NULL)
@@@ -161,10 -160,10 +161,10 @@@
        fclose(Fout);
        unlink(*FileName);
        if (rename(FoutTmpName, *FileName) != 0) {
-           char DefaultName[STRLEN];
+           char DefaultName[STRLEN+1];
+           memset(DefaultName, '\0', sizeof(DefaultName));
            if ( (strlen(FullPath) + strlen(DEFAULT_OUT_NAME)) > STRLEN-1 ) GIF_EXIT("Filename too long.");
            strncpy(DefaultName, FullPath, STRLEN);
-           // cppcheck-suppress uninitstring
            strcat(DefaultName, DEFAULT_OUT_NAME);
            if (rename(FoutTmpName, DefaultName) == 0) {
                char s[STRLEN];

diff --combined giftext.c
index 864f2d5,bb12c7c..523ada9
--- 1/util/giftext.c
--- 2/giftext.c
+++ b/giftext.c
@@@ -21,9 -21,8 +21,9 @@@ giftext - dump GIF pixels and metadata 
  
  #define MAKE_PRINTABLE(c)  (isprint(c) ? (c) : ' ')
  
 +__attribute__((__section__(".tizen.build-id")))
  static char
 -    *VersionStr =
 +    VersionStr[] =
        PROGRAM_NAME
        VERSION_COOKIE
        "       Gershon Elber,  "
@@@ -315,11 -314,11 +315,11 @@@ static void PrintCodeBlock(GifFileType 
  {
      static int CrntPlace = 0; 
      static long CodeCount = 0;
-     int i, Percent, Len;
-     long NumBytes;
+     int i, Len;
  
      if (Reset || CodeBlock == NULL) {
        if (CodeBlock == NULL) {
+           long NumBytes = 0;
            if (CrntPlace > 0) {
                printf("\n");
                CodeCount += CrntPlace - 16;
@@@ -327,12 -326,15 +327,15 @@@
            if (GifFile->Image.ColorMap)
                NumBytes = ((((long) GifFile->Image.Width) * GifFile->Image.Height)
                                * GifFile->Image.ColorMap->BitsPerPixel) / 8;
-           else
+           else if (GifFile->SColorMap != NULL)
                NumBytes = ((((long) GifFile->Image.Width) * GifFile->Image.Height)
                                * GifFile->SColorMap->BitsPerPixel) / 8;
-           Percent = 100 * CodeCount / NumBytes;
-           printf("\nCompression ratio: %ld/%ld (%d%%).\n",
+           /* FIXME: What should the compression ratio be if no color table? */
+           if (NumBytes > 0) {
+               int Percent = 100 * CodeCount / NumBytes;
+               printf("\nCompression ratio: %ld/%ld (%d%%).\n",
                        CodeCount, NumBytes, Percent);
+           }
            return;
        }
        CrntPlace = 0;

diff --combined gifwedge.c
index d8be2d9,a8f587f..d8be2d9
--- 1/util/gifwedge.c
--- 2/gifwedge.c
+++ b/gifwedge.c
@@@ -20,9 -20,8 +20,9 @@@ gifwedge - create a GIF test patter
  
  #define DEFAULT_NUM_LEVELS    16     /* Number of colors to gen the image. */
  
 +__attribute__((__section__(".tizen.build-id")))
  static char
 -    *VersionStr =
 +    VersionStr[] =
        PROGRAM_NAME
        VERSION_COOKIE
        "       Gershon Elber,  "