video: Referencing 'E_Comp_Wl_Buffer' before pp commit. 58/224758/1
authorSeunghun Lee <shiin.lee@samsung.com>
Wed, 18 Dec 2019 06:17:12 +0000 (15:17 +0900)
committerSeunghun Lee <shiin.lee@samsung.com>
Thu, 13 Feb 2020 02:02:09 +0000 (11:02 +0900)
A handler for pp commit done can be called directly in tdm_pp_commit().
Therefore, a buffer has to be referenced before calling it for safety.

Change-Id: Ief542676d8f6425e4951598796140f8cceb740c6

src/bin/video/iface/e_video_hwc.c

index 00572cb2fe3369e5d338f69882c912c7d3da657a..21a6b2b50c3b6ae0bcf09310a3ef404523d74066 100644 (file)
@@ -558,13 +558,13 @@ _e_video_hwc_pp_render(E_Video_Hwc *evh, E_Comp_Wl_Buffer *comp_buffer)
    if (!pp_buffer)
      goto render_fail;
 
+   e_comp_wl_video_buffer_set_use(pp_buffer, EINA_TRUE);
+   e_comp_wl_buffer_reference(&input_buffer->buffer_ref, input_buffer->comp_buffer);
+
    res = _e_video_hwc_pp_commit(evh->pp, input_buffer, pp_buffer, evh->geo.tdm.transform);
    if (!res)
      goto render_fail;
 
-   e_comp_wl_video_buffer_set_use(pp_buffer, EINA_TRUE);
-   e_comp_wl_buffer_reference(&input_buffer->buffer_ref, input_buffer->comp_buffer);
-
    return EINA_TRUE;
 
 render_fail: