net: wwan: iosm: fix crash in peek throughput test
authorM Chetan Kumar <m.chetan.kumar@linux.intel.com>
Thu, 24 Nov 2022 10:38:17 +0000 (16:08 +0530)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Nov 2022 11:31:59 +0000 (11:31 +0000)
Peek throughput UL test is resulting in crash. If the UL
transfer block free list is exhaust, the peeked skb is freed.
In the next transfer freed skb is referred from UL list which
results in crash.

Don't free the skb if UL transfer blocks are unavailable. The
pending skb will be picked for transfer on UL transfer block
available.

Fixes: 1f52d7b62285 ("net: wwan: iosm: Enable M.2 7360 WWAN card support")
Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wwan/iosm/iosm_ipc_mux_codec.c

index c163651..738420b 100644 (file)
@@ -1207,10 +1207,9 @@ static int mux_ul_dg_update_tbl_index(struct iosm_mux *ipc_mux,
                                 qlth_n_ql_size, ul_list);
        ipc_mux_ul_adb_finish(ipc_mux);
        if (ipc_mux_ul_adb_allocate(ipc_mux, adb, &ipc_mux->size_needed,
-                                   IOSM_AGGR_MUX_SIG_ADBH)) {
-               dev_kfree_skb(src_skb);
+                                   IOSM_AGGR_MUX_SIG_ADBH))
                return -ENOMEM;
-       }
+
        ipc_mux->size_needed = le32_to_cpu(adb->adbh->block_length);
 
        ipc_mux->size_needed += offsetof(struct mux_adth, dg);