image.h: make image_sign_info.fit point to const
authorHannu Lounento <hannu.lounento@vaisala.com>
Mon, 18 Oct 2021 05:49:03 +0000 (08:49 +0300)
committerSimon Glass <sjg@chromium.org>
Sun, 31 Oct 2021 18:26:44 +0000 (12:26 -0600)
The data blob apparently does not need to be modified through the fit
field of the image_sign_info struct so make it point to const to avoid
the need to cast away constness in functions that assign a pointer to
const data to the field.

fit_image_setup_verify already had to cast away constness as it assigned
a const void * argument to the field. The cast can now be removed.

Signed-off-by: Hannu Lounento <hannu.lounento@vaisala.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
common/image-fit-sig.c
include/image.h

index 4edebbf..63e5423 100644 (file)
@@ -85,7 +85,7 @@ static int fit_image_setup_verify(struct image_sign_info *info,
 
        memset(info, '\0', sizeof(*info));
        info->keyname = fdt_getprop(fit, noffset, FIT_KEY_HINT, NULL);
-       info->fit = (void *)fit;
+       info->fit = fit;
        info->node_offset = noffset;
        info->name = algo_name;
        info->checksum = image_get_checksum_algo(algo_name);
index 34d13ad..fd662e7 100644 (file)
@@ -1159,7 +1159,7 @@ struct image_sign_info {
        const char *keydir;             /* Directory conaining keys */
        const char *keyname;            /* Name of key to use */
        const char *keyfile;            /* Filename of private or public key */
-       void *fit;                      /* Pointer to FIT blob */
+       const void *fit;                /* Pointer to FIT blob */
        int node_offset;                /* Offset of signature node */
        const char *name;               /* Algorithm name */
        struct checksum_algo *checksum; /* Checksum algorithm information */