misc: lis3lv02d: Do not log an error when kmalloc fails
authorHans de Goede <hdegoede@redhat.com>
Wed, 17 Feb 2021 10:25:01 +0000 (11:25 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Mar 2021 07:26:29 +0000 (08:26 +0100)
Logging an error when kmalloc fails is not necessary (and in general
should be avoided) because the malloc failure will already complain
loudly itself.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210217102501.31758-3-hdegoede@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/lis3lv02d/lis3lv02d.c

index 22dacfa..70c5bb1 100644 (file)
@@ -1179,10 +1179,8 @@ int lis3lv02d_init_device(struct lis3lv02d *lis3)
        lis3->reg_cache = kzalloc(max(sizeof(lis3_wai8_regs),
                                     sizeof(lis3_wai12_regs)), GFP_KERNEL);
 
-       if (lis3->reg_cache == NULL) {
-               printk(KERN_ERR DRIVER_NAME "out of memory\n");
+       if (lis3->reg_cache == NULL)
                return -ENOMEM;
-       }
 
        mutex_init(&lis3->mutex);
        atomic_set(&lis3->wake_thread, 0);