ASoC: soc-compress: Fix deadlock in soc_compr_open_fe
authoryixuanjiang <yixuanjiang@google.com>
Mon, 19 Jun 2023 03:31:27 +0000 (11:31 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 21 Jun 2023 12:42:44 +0000 (13:42 +0100)
Modify the error handling flow by release lock.
The require mutex will keep holding if open fail.

Fixes: aa9ff6a4955f ("ASoC: soc-compress: Reposition and add pcm_mutex")
Signed-off-by: yixuanjiang <yixuanjiang@google.com>
Link: https://lore.kernel.org/r/20230619033127.2522477-1-yixuanjiang@google.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-compress.c

index d8715db..2117fd6 100644 (file)
@@ -194,6 +194,7 @@ open_err:
        snd_soc_dai_compr_shutdown(cpu_dai, cstream, 1);
 out:
        dpcm_path_put(&list);
+       snd_soc_dpcm_mutex_unlock(fe);
 be_err:
        fe->dpcm[stream].runtime_update = SND_SOC_DPCM_UPDATE_NO;
        snd_soc_card_mutex_unlock(fe->card);