staging:rtl8192u: Remove charData and rename shortData - Style
authorJohn Whitmore <johnfwhitmore@gmail.com>
Tue, 21 Aug 2018 17:15:26 +0000 (18:15 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Aug 2018 17:24:30 +0000 (19:24 +0200)
The union ba_param_set contains the member variable charData which is
unused. The variable has been removed.

Additionally the member variable shortData has been renamed to clear
a checkpatch issue with CamelCase naming.

These are coding style changes which should not impact runtime code
execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c

index 44f8204..d3730fc 100644 (file)
@@ -31,8 +31,7 @@ union sequence_control {
 };
 
 union ba_param_set {
-       u8 charData[2];
-       u16 shortData;
+       u16 short_data;
        struct {
                u16 AMSDU_Support:1;
                u16 BAPolicy:1;
index 469e3e9..1a92715 100644 (file)
@@ -90,7 +90,7 @@ static u8 RxTsDeleteBA(struct ieee80211_device *ieee, struct rx_ts_record *pRxTs
 void ResetBaEntry(PBA_RECORD pBA)
 {
        pBA->bValid                     = false;
-       pBA->BaParamSet.shortData       = 0;
+       pBA->BaParamSet.short_data      = 0;
        pBA->BaTimeoutValue             = 0;
        pBA->DialogToken                = 0;
        pBA->BaStartSeqCtrl.short_data  = 0;
@@ -151,7 +151,7 @@ static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, P
        }
        // BA Parameter Set
 
-       put_unaligned_le16(pBA->BaParamSet.shortData, tag);
+       put_unaligned_le16(pBA->BaParamSet.short_data, tag);
        tag += 2;
        // BA Timeout Value