rtw88: signal completion even on firmware-request failure
authorBrian Norris <briannorris@chromium.org>
Wed, 6 Nov 2019 21:30:55 +0000 (13:30 -0800)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 8 Nov 2019 08:27:03 +0000 (10:27 +0200)
Otherwise, the waiters (e.g., "modprobe rtwpci") will block forever.

Fixes: f530c1961af2 ("rtw88: fix potential NULL pointer access for firmware")
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
Signed-off-by: Brian Norris <briannorris@chromium.org>
Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtw88/main.c

index de82d08..ae61415 100644 (file)
@@ -1026,6 +1026,7 @@ static void rtw_load_firmware_cb(const struct firmware *firmware, void *context)
 
        if (!firmware || !firmware->data) {
                rtw_err(rtwdev, "failed to request firmware\n");
+               complete_all(&fw->completion);
                return;
        }