crypto: caam - add crypto_engine support for HASH algorithms
authorIuliana Prodan <iuliana.prodan@nxp.com>
Wed, 12 Feb 2020 17:55:24 +0000 (19:55 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 22 Feb 2020 01:25:48 +0000 (09:25 +0800)
Add crypto_engine support for HASH algorithms, to make use of
the engine queue.
The requests, with backlog flag, will be listed into crypto-engine
queue and processed by CAAM when free.
Only the backlog request are sent to crypto-engine since the others
can be handled by CAAM, if free, especially since JR has up to 1024
entries (more than the 10 entries from crypto-engine).

Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/caam/caamhash.c

index 2af9e66..2fe8528 100644 (file)
@@ -65,6 +65,7 @@
 #include "sg_sw_sec4.h"
 #include "key_gen.h"
 #include "caamhash_desc.h"
+#include <crypto/engine.h>
 
 #define CAAM_CRA_PRIORITY              3000
 
@@ -86,6 +87,7 @@ static struct list_head hash_list;
 
 /* ahash per-session context */
 struct caam_hash_ctx {
+       struct crypto_engine_ctx enginectx;
        u32 sh_desc_update[DESC_HASH_MAX_USED_LEN] ____cacheline_aligned;
        u32 sh_desc_update_first[DESC_HASH_MAX_USED_LEN] ____cacheline_aligned;
        u32 sh_desc_fin[DESC_HASH_MAX_USED_LEN] ____cacheline_aligned;
@@ -111,9 +113,12 @@ struct caam_hash_state {
        int buflen;
        int next_buflen;
        u8 caam_ctx[MAX_CTX_LEN] ____cacheline_aligned;
-       int (*update)(struct ahash_request *req);
+       int (*update)(struct ahash_request *req) ____cacheline_aligned;
        int (*final)(struct ahash_request *req);
        int (*finup)(struct ahash_request *req);
+       struct ahash_edesc *edesc;
+       void (*ahash_op_done)(struct device *jrdev, u32 *desc, u32 err,
+                             void *context);
 };
 
 struct caam_export_state {
@@ -521,6 +526,7 @@ static int acmac_setkey(struct crypto_ahash *ahash, const u8 *key,
  * @sec4_sg_dma: physical mapped address of h/w link table
  * @src_nents: number of segments in input scatterlist
  * @sec4_sg_bytes: length of dma mapped sec4_sg space
+ * @bklog: stored to determine if the request needs backlog
  * @hw_desc: the h/w job descriptor followed by any referenced link tables
  * @sec4_sg: h/w link table
  */
@@ -528,6 +534,7 @@ struct ahash_edesc {
        dma_addr_t sec4_sg_dma;
        int src_nents;
        int sec4_sg_bytes;
+       bool bklog;
        u32 hw_desc[DESC_JOB_IO_LEN_MAX / sizeof(u32)] ____cacheline_aligned;
        struct sec4_sg_entry sec4_sg[0];
 };
@@ -569,6 +576,7 @@ static inline void ahash_done_cpy(struct device *jrdev, u32 *desc, u32 err,
                                  void *context, enum dma_data_direction dir)
 {
        struct ahash_request *req = context;
+       struct caam_drv_private_jr *jrp = dev_get_drvdata(jrdev);
        struct ahash_edesc *edesc;
        struct crypto_ahash *ahash = crypto_ahash_reqtfm(req);
        int digestsize = crypto_ahash_digestsize(ahash);
@@ -578,7 +586,8 @@ static inline void ahash_done_cpy(struct device *jrdev, u32 *desc, u32 err,
 
        dev_dbg(jrdev, "%s %d: err 0x%x\n", __func__, __LINE__, err);
 
-       edesc = container_of(desc, struct ahash_edesc, hw_desc[0]);
+       edesc = state->edesc;
+
        if (err)
                ecode = caam_jr_strstatus(jrdev, err);
 
@@ -590,7 +599,14 @@ static inline void ahash_done_cpy(struct device *jrdev, u32 *desc, u32 err,
                             DUMP_PREFIX_ADDRESS, 16, 4, state->caam_ctx,
                             ctx->ctx_len, 1);
 
-       req->base.complete(&req->base, ecode);
+       /*
+        * If no backlog flag, the completion of the request is done
+        * by CAAM, not crypto engine.
+        */
+       if (!edesc->bklog)
+               req->base.complete(&req->base, ecode);
+       else
+               crypto_finalize_hash_request(jrp->engine, req, ecode);
 }
 
 static void ahash_done(struct device *jrdev, u32 *desc, u32 err,
@@ -609,6 +625,7 @@ static inline void ahash_done_switch(struct device *jrdev, u32 *desc, u32 err,
                                     void *context, enum dma_data_direction dir)
 {
        struct ahash_request *req = context;
+       struct caam_drv_private_jr *jrp = dev_get_drvdata(jrdev);
        struct ahash_edesc *edesc;
        struct crypto_ahash *ahash = crypto_ahash_reqtfm(req);
        struct caam_hash_ctx *ctx = crypto_ahash_ctx(ahash);
@@ -618,7 +635,7 @@ static inline void ahash_done_switch(struct device *jrdev, u32 *desc, u32 err,
 
        dev_dbg(jrdev, "%s %d: err 0x%x\n", __func__, __LINE__, err);
 
-       edesc = container_of(desc, struct ahash_edesc, hw_desc[0]);
+       edesc = state->edesc;
        if (err)
                ecode = caam_jr_strstatus(jrdev, err);
 
@@ -642,7 +659,15 @@ static inline void ahash_done_switch(struct device *jrdev, u32 *desc, u32 err,
                                     DUMP_PREFIX_ADDRESS, 16, 4, req->result,
                                     digestsize, 1);
 
-       req->base.complete(&req->base, ecode);
+       /*
+        * If no backlog flag, the completion of the request is done
+        * by CAAM, not crypto engine.
+        */
+       if (!edesc->bklog)
+               req->base.complete(&req->base, ecode);
+       else
+               crypto_finalize_hash_request(jrp->engine, req, ecode);
+
 }
 
 static void ahash_done_bi(struct device *jrdev, u32 *desc, u32 err,
@@ -667,6 +692,7 @@ static struct ahash_edesc *ahash_edesc_alloc(struct ahash_request *req,
 {
        struct crypto_ahash *ahash = crypto_ahash_reqtfm(req);
        struct caam_hash_ctx *ctx = crypto_ahash_ctx(ahash);
+       struct caam_hash_state *state = ahash_request_ctx(req);
        gfp_t flags = (req->base.flags & CRYPTO_TFM_REQ_MAY_SLEEP) ?
                       GFP_KERNEL : GFP_ATOMIC;
        struct ahash_edesc *edesc;
@@ -678,6 +704,8 @@ static struct ahash_edesc *ahash_edesc_alloc(struct ahash_request *req,
                return NULL;
        }
 
+       state->edesc = edesc;
+
        init_job_desc_shared(edesc->hw_desc, sh_desc_dma, desc_len(sh_desc),
                             HDR_SHARE_DEFER | HDR_REVERSE);
 
@@ -720,6 +748,62 @@ static int ahash_edesc_add_src(struct caam_hash_ctx *ctx,
        return 0;
 }
 
+static int ahash_do_one_req(struct crypto_engine *engine, void *areq)
+{
+       struct ahash_request *req = ahash_request_cast(areq);
+       struct caam_hash_ctx *ctx = crypto_ahash_ctx(crypto_ahash_reqtfm(req));
+       struct caam_hash_state *state = ahash_request_ctx(req);
+       struct device *jrdev = ctx->jrdev;
+       u32 *desc = state->edesc->hw_desc;
+       int ret;
+
+       state->edesc->bklog = true;
+
+       ret = caam_jr_enqueue(jrdev, desc, state->ahash_op_done, req);
+
+       if (ret != -EINPROGRESS) {
+               ahash_unmap(jrdev, state->edesc, req, 0);
+               kfree(state->edesc);
+       } else {
+               ret = 0;
+       }
+
+       return ret;
+}
+
+static int ahash_enqueue_req(struct device *jrdev,
+                            void (*cbk)(struct device *jrdev, u32 *desc,
+                                        u32 err, void *context),
+                            struct ahash_request *req,
+                            int dst_len, enum dma_data_direction dir)
+{
+       struct caam_drv_private_jr *jrpriv = dev_get_drvdata(jrdev);
+       struct caam_hash_state *state = ahash_request_ctx(req);
+       struct ahash_edesc *edesc = state->edesc;
+       u32 *desc = edesc->hw_desc;
+       int ret;
+
+       state->ahash_op_done = cbk;
+
+       /*
+        * Only the backlog request are sent to crypto-engine since the others
+        * can be handled by CAAM, if free, especially since JR has up to 1024
+        * entries (more than the 10 entries from crypto-engine).
+        */
+       if (req->base.flags & CRYPTO_TFM_REQ_MAY_BACKLOG)
+               ret = crypto_transfer_hash_request_to_engine(jrpriv->engine,
+                                                            req);
+       else
+               ret = caam_jr_enqueue(jrdev, desc, cbk, req);
+
+       if ((ret != -EINPROGRESS) && (ret != -EBUSY)) {
+               ahash_unmap_ctx(jrdev, edesc, req, dst_len, dir);
+               kfree(edesc);
+       }
+
+       return ret;
+}
+
 /* submit update job descriptor */
 static int ahash_update_ctx(struct ahash_request *req)
 {
@@ -827,9 +911,8 @@ static int ahash_update_ctx(struct ahash_request *req)
                                     DUMP_PREFIX_ADDRESS, 16, 4, desc,
                                     desc_bytes(desc), 1);
 
-               ret = caam_jr_enqueue(jrdev, desc, ahash_done_bi, req);
-               if (ret != -EINPROGRESS)
-                       goto unmap_ctx;
+               ret = ahash_enqueue_req(jrdev, ahash_done_bi, req,
+                                       ctx->ctx_len, DMA_BIDIRECTIONAL);
        } else if (*next_buflen) {
                scatterwalk_map_and_copy(buf + *buflen, req->src, 0,
                                         req->nbytes, 0);
@@ -900,10 +983,8 @@ static int ahash_final_ctx(struct ahash_request *req)
                             DUMP_PREFIX_ADDRESS, 16, 4, desc, desc_bytes(desc),
                             1);
 
-       ret = caam_jr_enqueue(jrdev, desc, ahash_done_ctx_src, req);
-       if (ret == -EINPROGRESS)
-               return ret;
-
+       return ahash_enqueue_req(jrdev, ahash_done_ctx_src, req,
+                                digestsize, DMA_BIDIRECTIONAL);
  unmap_ctx:
        ahash_unmap_ctx(jrdev, edesc, req, digestsize, DMA_BIDIRECTIONAL);
        kfree(edesc);
@@ -976,10 +1057,8 @@ static int ahash_finup_ctx(struct ahash_request *req)
                             DUMP_PREFIX_ADDRESS, 16, 4, desc, desc_bytes(desc),
                             1);
 
-       ret = caam_jr_enqueue(jrdev, desc, ahash_done_ctx_src, req);
-       if (ret == -EINPROGRESS)
-               return ret;
-
+       return ahash_enqueue_req(jrdev, ahash_done_ctx_src, req,
+                                digestsize, DMA_BIDIRECTIONAL);
  unmap_ctx:
        ahash_unmap_ctx(jrdev, edesc, req, digestsize, DMA_BIDIRECTIONAL);
        kfree(edesc);
@@ -1048,13 +1127,8 @@ static int ahash_digest(struct ahash_request *req)
                             DUMP_PREFIX_ADDRESS, 16, 4, desc, desc_bytes(desc),
                             1);
 
-       ret = caam_jr_enqueue(jrdev, desc, ahash_done, req);
-       if (ret != -EINPROGRESS) {
-               ahash_unmap_ctx(jrdev, edesc, req, digestsize, DMA_FROM_DEVICE);
-               kfree(edesc);
-       }
-
-       return ret;
+       return ahash_enqueue_req(jrdev, ahash_done, req, digestsize,
+                                DMA_FROM_DEVICE);
 }
 
 /* submit ahash final if it the first job descriptor */
@@ -1098,18 +1172,12 @@ static int ahash_final_no_ctx(struct ahash_request *req)
                             DUMP_PREFIX_ADDRESS, 16, 4, desc, desc_bytes(desc),
                             1);
 
-       ret = caam_jr_enqueue(jrdev, desc, ahash_done, req);
-       if (ret != -EINPROGRESS) {
-               ahash_unmap_ctx(jrdev, edesc, req, digestsize, DMA_FROM_DEVICE);
-               kfree(edesc);
-       }
-
-       return ret;
+       return ahash_enqueue_req(jrdev, ahash_done, req,
+                                digestsize, DMA_FROM_DEVICE);
  unmap:
        ahash_unmap(jrdev, edesc, req, digestsize);
        kfree(edesc);
        return -ENOMEM;
-
 }
 
 /* submit ahash update if it the first job descriptor after update */
@@ -1209,10 +1277,10 @@ static int ahash_update_no_ctx(struct ahash_request *req)
                                     DUMP_PREFIX_ADDRESS, 16, 4, desc,
                                     desc_bytes(desc), 1);
 
-               ret = caam_jr_enqueue(jrdev, desc, ahash_done_ctx_dst, req);
-               if (ret != -EINPROGRESS)
-                       goto unmap_ctx;
-
+               ret = ahash_enqueue_req(jrdev, ahash_done_ctx_dst, req,
+                                       ctx->ctx_len, DMA_TO_DEVICE);
+               if ((ret != -EINPROGRESS) && (ret != -EBUSY))
+                       return ret;
                state->update = ahash_update_ctx;
                state->finup = ahash_finup_ctx;
                state->final = ahash_final_ctx;
@@ -1300,13 +1368,8 @@ static int ahash_finup_no_ctx(struct ahash_request *req)
                             DUMP_PREFIX_ADDRESS, 16, 4, desc, desc_bytes(desc),
                             1);
 
-       ret = caam_jr_enqueue(jrdev, desc, ahash_done, req);
-       if (ret != -EINPROGRESS) {
-               ahash_unmap_ctx(jrdev, edesc, req, digestsize, DMA_FROM_DEVICE);
-               kfree(edesc);
-       }
-
-       return ret;
+       return ahash_enqueue_req(jrdev, ahash_done, req,
+                                digestsize, DMA_FROM_DEVICE);
  unmap:
        ahash_unmap(jrdev, edesc, req, digestsize);
        kfree(edesc);
@@ -1394,10 +1457,10 @@ static int ahash_update_first(struct ahash_request *req)
                                     DUMP_PREFIX_ADDRESS, 16, 4, desc,
                                     desc_bytes(desc), 1);
 
-               ret = caam_jr_enqueue(jrdev, desc, ahash_done_ctx_dst, req);
-               if (ret != -EINPROGRESS)
-                       goto unmap_ctx;
-
+               ret = ahash_enqueue_req(jrdev, ahash_done_ctx_dst, req,
+                                       ctx->ctx_len, DMA_TO_DEVICE);
+               if ((ret != -EINPROGRESS) && (ret != -EBUSY))
+                       return ret;
                state->update = ahash_update_ctx;
                state->finup = ahash_finup_ctx;
                state->final = ahash_final_ctx;
@@ -1700,6 +1763,8 @@ static int caam_hash_cra_init(struct crypto_tfm *tfm)
                                         HASH_MSG_LEN + SHA256_DIGEST_SIZE,
                                         HASH_MSG_LEN + 64,
                                         HASH_MSG_LEN + SHA512_DIGEST_SIZE };
+       const size_t sh_desc_update_offset = offsetof(struct caam_hash_ctx,
+                                                     sh_desc_update);
        dma_addr_t dma_addr;
        struct caam_drv_private *priv;
 
@@ -1752,7 +1817,8 @@ static int caam_hash_cra_init(struct crypto_tfm *tfm)
        }
 
        dma_addr = dma_map_single_attrs(ctx->jrdev, ctx->sh_desc_update,
-                                       offsetof(struct caam_hash_ctx, key),
+                                       offsetof(struct caam_hash_ctx, key) -
+                                       sh_desc_update_offset,
                                        ctx->dir, DMA_ATTR_SKIP_CPU_SYNC);
        if (dma_mapping_error(ctx->jrdev, dma_addr)) {
                dev_err(ctx->jrdev, "unable to map shared descriptors\n");
@@ -1770,11 +1836,16 @@ static int caam_hash_cra_init(struct crypto_tfm *tfm)
        ctx->sh_desc_update_dma = dma_addr;
        ctx->sh_desc_update_first_dma = dma_addr +
                                        offsetof(struct caam_hash_ctx,
-                                                sh_desc_update_first);
+                                                sh_desc_update_first) -
+                                       sh_desc_update_offset;
        ctx->sh_desc_fin_dma = dma_addr + offsetof(struct caam_hash_ctx,
-                                                  sh_desc_fin);
+                                                  sh_desc_fin) -
+                                       sh_desc_update_offset;
        ctx->sh_desc_digest_dma = dma_addr + offsetof(struct caam_hash_ctx,
-                                                     sh_desc_digest);
+                                                     sh_desc_digest) -
+                                       sh_desc_update_offset;
+
+       ctx->enginectx.op.do_one_request = ahash_do_one_req;
 
        crypto_ahash_set_reqsize(__crypto_ahash_cast(tfm),
                                 sizeof(struct caam_hash_state));
@@ -1791,7 +1862,8 @@ static void caam_hash_cra_exit(struct crypto_tfm *tfm)
        struct caam_hash_ctx *ctx = crypto_tfm_ctx(tfm);
 
        dma_unmap_single_attrs(ctx->jrdev, ctx->sh_desc_update_dma,
-                              offsetof(struct caam_hash_ctx, key),
+                              offsetof(struct caam_hash_ctx, key) -
+                              offsetof(struct caam_hash_ctx, sh_desc_update),
                               ctx->dir, DMA_ATTR_SKIP_CPU_SYNC);
        if (ctx->key_dir != DMA_NONE)
                dma_unmap_single_attrs(ctx->jrdev, ctx->adata.key_dma,