Extend check for integer overflow for malloc argument to take into account
authorReimar Döffinger <Reimar.Doeffinger@gmx.de>
Mon, 14 Sep 2009 17:15:18 +0000 (17:15 +0000)
committerReimar Döffinger <Reimar.Doeffinger@gmx.de>
Mon, 14 Sep 2009 17:15:18 +0000 (17:15 +0000)
also the addition of "sound_buffers" not only the multiplication.

Originally committed as revision 19840 to svn://svn.ffmpeg.org/ffmpeg/trunk

libavformat/sierravmd.c

index 52f0582..5aa5a04 100644 (file)
@@ -154,7 +154,7 @@ static int vmd_read_header(AVFormatContext *s,
     vmd->frame_table = NULL;
     sound_buffers = AV_RL16(&vmd->vmd_header[808]);
     raw_frame_table_size = vmd->frame_count * 6;
-    if(vmd->frame_count * vmd->frames_per_block  >= UINT_MAX / sizeof(vmd_frame)){
+    if(vmd->frame_count * vmd->frames_per_block  >= (UINT_MAX - sound_buffers) / sizeof(vmd_frame)){
         av_log(s, AV_LOG_ERROR, "vmd->frame_count * vmd->frames_per_block too large\n");
         return -1;
     }