tipc: fix the timer expires after interval 100ms
authorHoang Le <hoang.h.le@dektech.com.au>
Mon, 21 Mar 2022 04:22:29 +0000 (11:22 +0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:43 +0000 (14:23 +0200)
[ Upstream commit 6a7d8cff4a3301087dd139293e9bddcf63827282 ]

In the timer callback function tipc_sk_timeout(), we're trying to
reschedule another timeout to retransmit a setup request if destination
link is congested. But we use the incorrect timeout value
(msecs_to_jiffies(100)) instead of (jiffies + msecs_to_jiffies(100)),
so that the timer expires immediately, it's irrelevant for original
description.

In this commit we correct the timeout value in sk_reset_timer()

Fixes: 6787927475e5 ("tipc: buffer overflow handling in listener socket")
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
Link: https://lore.kernel.org/r/20220321042229.314288-1-hoang.h.le@dektech.com.au
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/tipc/socket.c

index 7545321..17f8c52 100644 (file)
@@ -2852,7 +2852,8 @@ static void tipc_sk_retry_connect(struct sock *sk, struct sk_buff_head *list)
 
        /* Try again later if dest link is congested */
        if (tsk->cong_link_cnt) {
-               sk_reset_timer(sk, &sk->sk_timer, msecs_to_jiffies(100));
+               sk_reset_timer(sk, &sk->sk_timer,
+                              jiffies + msecs_to_jiffies(100));
                return;
        }
        /* Prepare SYN for retransmit */