wpe: enable console message with WPE2
authorGuillaume Desmottes <guillaume.desmottes@onestream.live>
Tue, 17 Dec 2024 16:36:19 +0000 (17:36 +0100)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Wed, 18 Dec 2024 09:13:22 +0000 (09:13 +0000)
Looks like the WebKitConsoleMessage API is now available in WPE2 as well:
https://webkitgtk.org/reference/webkitgtk-web-process-extension/stable/signal.WebPage.console-message-sent.html

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8169>

subprojects/gst-plugins-bad/ext/wpe/wpe-extension/gstwpeextension.c

index 6bba314f978982f798939cc4963853c15feed108..96009dddba290676a94777262c442a72f26ab7af 100644 (file)
@@ -45,7 +45,6 @@ G_MODULE_EXPORT void extension_initialize (WebKitWebExtension * extension);
 
 static WebKitWebExtension *global_extension = NULL;
 
-#if !USE_WPE2
 static void
 console_message_cb (WebKitWebPage * page,
     WebKitConsoleMessage * console_message, gpointer data)
@@ -56,17 +55,13 @@ console_message_cb (WebKitWebPage * page,
       NULL);
   g_free (message);
 }
-#endif
 
 static void
 web_page_created_callback (WebKitWebExtension * extension,
     WebKitWebPage * web_page, gpointer data)
 {
-  // WebKitConsoleMessage is deprecated in wpe1 and has no replacement in wpe2.
-#if !USE_WPE2
   g_signal_connect (web_page, "console-message-sent",
       G_CALLBACK (console_message_cb), NULL);
-#endif
 }
 
 void