deinterlace: force -DPREFIX on macos
authorIgnacio Casal Quinteiro <qignacio@amazon.com>
Wed, 30 Dec 2020 12:38:46 +0000 (13:38 +0100)
committerIgnacio Casal Quinteiro <qignacio@amazon.com>
Wed, 30 Dec 2020 12:40:35 +0000 (13:40 +0100)
This is due to a bug in meson where it will not detect properly
the compiler if the symbols need an undercore.
https://github.com/mesonbuild/meson/issues/5482

Fixes #821

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/845>

gst/deinterlace/meson.build

index 4c747b7..5eae029 100644 (file)
@@ -49,7 +49,12 @@ if have_nasm and host_cpu == 'x86_64'
   endif
 
   # Assembly has to be told when the symbols have to be prefixed with _
-  if cc.symbols_have_underscore_prefix()
+  # Note that symbols_have_underscore_prefix does not work properly on macos
+  # if the compiler -g flag is used. See:
+  # https://github.com/mesonbuild/meson/issues/5482
+  if ['darwin', 'ios'].contains(host_system)
+    asm_prefix_def = '-DPREFIX'
+  elif cc.symbols_have_underscore_prefix()
     asm_prefix_def = '-DPREFIX'
   else
     asm_prefix_def = '-UPREFIX'