ASoC: uniphier: fix an error code in uniphier_aio_comprdma_new()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 14 Feb 2018 07:15:31 +0000 (10:15 +0300)
committerMark Brown <broonie@kernel.org>
Wed, 14 Feb 2018 11:47:15 +0000 (11:47 +0000)
The dma_mapping_error() returns true or false, but we want to return
-ENOMEM if there was an error.

Fixes: e98131222ff9 ("ASoC: uniphier: add support for UniPhier AIO compress audio")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/uniphier/aio-compress.c

index 7f7abe3..4751c8b 100644 (file)
@@ -54,12 +54,11 @@ static int uniphier_aio_comprdma_new(struct snd_soc_pcm_runtime *rtd)
                dma_dir = DMA_TO_DEVICE;
 
        sub->compr_addr = dma_map_single(dev, sub->compr_area, size, dma_dir);
-       ret = dma_mapping_error(dev, sub->compr_addr);
-       if (ret) {
+       if (dma_mapping_error(dev, sub->compr_addr)) {
                kfree(sub->compr_area);
                sub->compr_area = NULL;
 
-               return ret;
+               return -ENOMEM;
        }
 
        sub->compr_bytes = size;