cgroup/cpuset: no need to explicitly init a global static variable
authorDaniel Vacek <neelx@redhat.com>
Tue, 20 Dec 2022 15:14:15 +0000 (16:14 +0100)
committerTejun Heo <tj@kernel.org>
Wed, 4 Jan 2023 22:19:17 +0000 (12:19 -1000)
cpuset_rwsem is a static variable defined with DEFINE_STATIC_PERCPU_RWSEM().
It's initialized at build time and so there's no need for explicit runtime
init leaking one percpu int.

Signed-off-by: Daniel Vacek <neelx@redhat.com>
Reviewed-by: Aaron Tomlin <atomlin@atomlin.com>
Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cgroup/cpuset.c

index a29c0b1..87fe410 100644 (file)
@@ -3281,8 +3281,6 @@ struct cgroup_subsys cpuset_cgrp_subsys = {
 
 int __init cpuset_init(void)
 {
-       BUG_ON(percpu_init_rwsem(&cpuset_rwsem));
-
        BUG_ON(!alloc_cpumask_var(&top_cpuset.cpus_allowed, GFP_KERNEL));
        BUG_ON(!alloc_cpumask_var(&top_cpuset.effective_cpus, GFP_KERNEL));
        BUG_ON(!zalloc_cpumask_var(&top_cpuset.subparts_cpus, GFP_KERNEL));