PCI: Remove unused pci_lost_interrupt()
authorHeiner Kallweit <hkallweit1@gmail.com>
Tue, 28 Jul 2020 21:03:41 +0000 (23:03 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 29 Jul 2020 19:25:18 +0000 (14:25 -0500)
388c8c16abaf ("PCI: add routines for debugging and handling lost
interrupts") added pci_lost_interrupt() that apparently never has had a
single user.  Remove it.

Link: https://lore.kernel.org/r/e328d059-3068-6a40-28df-f81f616d15a0@gmail.com
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/irq.c
include/linux/pci.h

index a1de501a27299bdd7856979e71baa4aa641e9a0a..12ecd0aaa28d6dbd331f2da7c8aaae4c3ffe22da 100644 (file)
@@ -6,61 +6,11 @@
  * Copyright (C) 2017 Christoph Hellwig.
  */
 
-#include <linux/acpi.h>
 #include <linux/device.h>
 #include <linux/kernel.h>
 #include <linux/export.h>
 #include <linux/pci.h>
 
-static void pci_note_irq_problem(struct pci_dev *pdev, const char *reason)
-{
-       struct pci_dev *parent = to_pci_dev(pdev->dev.parent);
-
-       pci_err(pdev, "Potentially misrouted IRQ (Bridge %s %04x:%04x)\n",
-               dev_name(&parent->dev), parent->vendor, parent->device);
-       pci_err(pdev, "%s\n", reason);
-       pci_err(pdev, "Please report to linux-kernel@vger.kernel.org\n");
-       WARN_ON(1);
-}
-
-/**
- * pci_lost_interrupt - reports a lost PCI interrupt
- * @pdev:      device whose interrupt is lost
- *
- * The primary function of this routine is to report a lost interrupt
- * in a standard way which users can recognise (instead of blaming the
- * driver).
- *
- * Returns:
- * a suggestion for fixing it (although the driver is not required to
- * act on this).
- */
-enum pci_lost_interrupt_reason pci_lost_interrupt(struct pci_dev *pdev)
-{
-       if (pdev->msi_enabled || pdev->msix_enabled) {
-               enum pci_lost_interrupt_reason ret;
-
-               if (pdev->msix_enabled) {
-                       pci_note_irq_problem(pdev, "MSIX routing failure");
-                       ret = PCI_LOST_IRQ_DISABLE_MSIX;
-               } else {
-                       pci_note_irq_problem(pdev, "MSI routing failure");
-                       ret = PCI_LOST_IRQ_DISABLE_MSI;
-               }
-               return ret;
-       }
-#ifdef CONFIG_ACPI
-       if (!(acpi_disabled || acpi_noirq)) {
-               pci_note_irq_problem(pdev, "Potential ACPI misrouting please reboot with acpi=noirq");
-               /* currently no way to fix acpi on the fly */
-               return PCI_LOST_IRQ_DISABLE_ACPI;
-       }
-#endif
-       pci_note_irq_problem(pdev, "unknown cause (not MSI or ACPI)");
-       return PCI_LOST_IRQ_NO_INFORMATION;
-}
-EXPORT_SYMBOL(pci_lost_interrupt);
-
 /**
  * pci_request_irq - allocate an interrupt line for a PCI device
  * @dev:       PCI device to operate on
index c79d83304e5293330f38ebb73a630daa499c9a6c..2dcd67f509a8c8c3100dec816e4855e7e94a1aa4 100644 (file)
@@ -1053,13 +1053,6 @@ void pci_sort_breadthfirst(void);
 
 /* Generic PCI functions exported to card drivers */
 
-enum pci_lost_interrupt_reason {
-       PCI_LOST_IRQ_NO_INFORMATION = 0,
-       PCI_LOST_IRQ_DISABLE_MSI,
-       PCI_LOST_IRQ_DISABLE_MSIX,
-       PCI_LOST_IRQ_DISABLE_ACPI,
-};
-enum pci_lost_interrupt_reason pci_lost_interrupt(struct pci_dev *dev);
 int pci_find_capability(struct pci_dev *dev, int cap);
 int pci_find_next_capability(struct pci_dev *dev, u8 pos, int cap);
 int pci_find_ext_capability(struct pci_dev *dev, int cap);