s390/qeth: remove useless if/else
authorKaixu Xia <kaixuxia@tencent.com>
Tue, 17 Nov 2020 16:15:14 +0000 (17:15 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 19 Nov 2020 01:34:18 +0000 (17:34 -0800)
Fix the following coccinelle report:

./drivers/s390/net/qeth_l3_main.c:107:2-4: WARNING: possible condition with no effect (if == else)

Both branches are the same since
commit ab29c480b194 ("s390/qeth: replace deprecated simple_stroul()"),
so remove them.

Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
[jwi: point to the commit that introduced this]
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/s390/net/qeth_l3_main.c

index b1c1d25..264b6c7 100644 (file)
@@ -104,10 +104,7 @@ static bool qeth_l3_is_addr_covered_by_ipato(struct qeth_card *card,
                qeth_l3_convert_addr_to_bits(ipatoe->addr, ipatoe_bits,
                                          (ipatoe->proto == QETH_PROT_IPV4) ?
                                          4 : 16);
-               if (addr->proto == QETH_PROT_IPV4)
-                       rc = !memcmp(addr_bits, ipatoe_bits, ipatoe->mask_bits);
-               else
-                       rc = !memcmp(addr_bits, ipatoe_bits, ipatoe->mask_bits);
+               rc = !memcmp(addr_bits, ipatoe_bits, ipatoe->mask_bits);
                if (rc)
                        break;
        }