namespace lldb_private {
class StringList {
- typedef std::vector<std::string> StorageType;
+ typedef std::vector<std::string> collection;
public:
StringList();
size_t GetMaxStringLength() const;
- typedef StorageType::iterator iterator;
- typedef StorageType::const_iterator const_iterator;
+ typedef collection::iterator iterator;
+ typedef collection::const_iterator const_iterator;
iterator begin() { return m_strings.begin(); }
iterator end() { return m_strings.end(); }
}
private:
- StorageType m_strings;
+ collection m_strings;
};
} // namespace lldb_private
Status error;
for (const std::string &type_name : options->m_target_types) {
- ConstString const_type_name(type_name);
- if (const_type_name) {
+ if (!type_name.empty()) {
if (!CommandObjectTypeSynthAdd::AddSynth(
- const_type_name, synth_provider,
+ ConstString(type_name), synth_provider,
options->m_regex
? CommandObjectTypeSynthAdd::eRegexSynth
: CommandObjectTypeSynthAdd::eRegularSynth,
}
void StringList::AppendList(StringList strings) {
+ m_strings.reserve(m_strings.size() + strings.GetSize());
m_strings.insert(m_strings.end(), strings.begin(), strings.end());
}
FAIL() << "Shouldn't have hit an element in for range" << e;
}
-TEST(StringListTest, ForRangeSingle) {
+TEST(StringListTest, ForRange) {
StringList s;
s.AppendString("a");
s.AppendString("b");