staging:iio:adc:ad7192 make use of iio_sw_buffer_preenable.
authorJonathan Cameron <jic23@kernel.org>
Sat, 21 Apr 2012 09:09:36 +0000 (10:09 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Apr 2012 18:23:37 +0000 (11:23 -0700)
This is not a fast path, so although the original code was more consise
use the generic case to cut down on code repitition.

Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/iio/adc/ad7192.c

index feb81f6..25ef3c3 100644 (file)
@@ -456,31 +456,19 @@ out:
 static int ad7192_ring_preenable(struct iio_dev *indio_dev)
 {
        struct ad7192_state *st = iio_priv(indio_dev);
-       struct iio_buffer *ring = indio_dev->buffer;
-       size_t d_size;
        unsigned channel;
+       int ret;
 
        if (bitmap_empty(indio_dev->active_scan_mask, indio_dev->masklength))
                return -EINVAL;
 
+       ret = iio_sw_buffer_preenable(indio_dev);
+       if (ret < 0)
+               return ret;
+
        channel = find_first_bit(indio_dev->active_scan_mask,
                                 indio_dev->masklength);
 
-       d_size = bitmap_weight(indio_dev->active_scan_mask,
-                              indio_dev->masklength) *
-                indio_dev->channels[0].scan_type.storagebits / 8;
-
-       if (ring->scan_timestamp) {
-               d_size += sizeof(s64);
-
-               if (d_size % sizeof(s64))
-                       d_size += sizeof(s64) - (d_size % sizeof(s64));
-       }
-
-       if (indio_dev->buffer->access->set_bytes_per_datum)
-               indio_dev->buffer->access->
-                       set_bytes_per_datum(indio_dev->buffer, d_size);
-
        st->mode  = (st->mode & ~AD7192_MODE_SEL(-1)) |
                    AD7192_MODE_SEL(AD7192_MODE_CONT);
        st->conf  = (st->conf & ~AD7192_CONF_CHAN(-1)) |