Turn on -Werror flag during compilation.

[Issue#]   N/A
[Bug]      N/A
[Problem]  New code adds compilation warnings.
[Solution] Warnings will be treated as errors.

[Verification] Successful build.

Change-Id: I2edd170f5ed3bbe4fcb189579274908ae76ec1f5

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4003ffd..0ae305b 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -63,7 +63,7 @@ ADD_DEFINITIONS("-fPIC")
 #ADD_DEFINITIONS("-fvisibility=hidden")
 
 # Set compiler warning flags
-#ADD_DEFINITIONS("-Werror")                      # Make all warnings into errors.
+ADD_DEFINITIONS("-Werror")                      # Make all warnings into errors.
 ADD_DEFINITIONS("-Wall")                        # Generate all warnings
 ADD_DEFINITIONS("-Wextra")                      # Generate even more extra warnings
 ADD_DEFINITIONS("-Wno-variadic-macros")         # Inhibit variadic macros warnings (needed for ORM)

diff --git a/tests/libprivilege-control-tests/CMakeLists.txt b/tests/libprivilege-control-tests/CMakeLists.txt
index f8fe64f..06458fa 100644 (file)
--- a/tests/libprivilege-control-tests/CMakeLists.txt
+++ b/tests/libprivilege-control-tests/CMakeLists.txt
@@ -36,8 +36,11 @@ SET(LPC_TARGET_TEST_SOURCES
     )
 
 #header directories
-INCLUDE_DIRECTORIES(
+INCLUDE_DIRECTORIES(SYSTEM
     ${LPC_TARGET_DEP_INCLUDE_DIRS}
+    )
+
+INCLUDE_DIRECTORIES(
     ${PROJECT_SOURCE_DIR}/tests/common/
     )
 

diff --git a/tests/libprivilege-control-tests/test_cases.cpp b/tests/libprivilege-control-tests/test_cases.cpp
index 404420c..4935cd3 100644 (file)
--- a/tests/libprivilege-control-tests/test_cases.cpp
+++ b/tests/libprivilege-control-tests/test_cases.cpp
@@ -389,7 +389,7 @@ typedef std::unique_ptr<int, std::function<void (int*)> > FDUniquePtr;
 std::vector<std::string> gen_names(std::string prefix, std::string suffix, size_t size)
 {
     std::vector<std::string> names;
-    for(int i = 0; i < size; ++i) {
+    for(size_t i = 0; i < size; ++i) {
         names.push_back(prefix + "_" + std::to_string(i) + suffix);
     }
     return names;
@@ -713,10 +713,10 @@ void remove_smack_files()
     unlink(WRT_BLAHBLAH_DAC);
     unlink(OTHER_BLAHBLAH_DAC);
 
-    for(int i=0;i<OSP_BLAHBLAH_DAC.size();++i )
+    for (size_t i = 0; i < OSP_BLAHBLAH_DAC.size(); ++i)
         unlink(OSP_BLAHBLAH_DAC[i].c_str());
 
-    for(int i=0;i<OSP_BLAHBLAH_DAC.size();++i )
+    for (size_t i = 0; i < OSP_BLAHBLAH_DAC.size(); ++i)
         unlink(OSP_BLAHBLAH_DAC[i].c_str());
 }
 

diff --git a/tests/libsmack-tests/CMakeLists.txt b/tests/libsmack-tests/CMakeLists.txt
index 582c4eb..cf1da99 100644 (file)
--- a/tests/libsmack-tests/CMakeLists.txt
+++ b/tests/libsmack-tests/CMakeLists.txt
@@ -34,8 +34,11 @@ SET(TARGET_TEST_SOURCES
     )
 
 #header directories
-INCLUDE_DIRECTORIES(
+INCLUDE_DIRECTORIES(SYSTEM
     ${TARGET_DEP_INCLUDE_DIRS}
+    )
+
+INCLUDE_DIRECTORIES(
     ${PROJECT_SOURCE_DIR}/tests/common/
     )
 

diff --git a/tests/security-server-client/CMakeLists.txt b/tests/security-server-client/CMakeLists.txt
index d81bc90..7c5034f 100644 (file)
--- a/tests/security-server-client/CMakeLists.txt
+++ b/tests/security-server-client/CMakeLists.txt
@@ -6,7 +6,7 @@ PKG_CHECK_MODULES(CLIENT2_DEP
     REQUIRED
     )
 
-INCLUDE_DIRECTORIES(
+INCLUDE_DIRECTORIES(SYSTEM
     ${CLIENT2_DEP_INCLUDE_DIRS}
     )
 

diff --git a/tests/security-server-tests/CMakeLists.txt b/tests/security-server-tests/CMakeLists.txt
index 2279dae..4fd4e4a 100644 (file)
--- a/tests/security-server-tests/CMakeLists.txt
+++ b/tests/security-server-tests/CMakeLists.txt
@@ -75,8 +75,11 @@ SET(SEC_SRV_MEASURER_SOURCES
     ${PROJECT_SOURCE_DIR}/tests/security-server-tests/security_server_mockup.cpp
    )
 
-INCLUDE_DIRECTORIES(
+INCLUDE_DIRECTORIES(SYSTEM
     ${SEC_SRV_TESTS_DEP_INCLUDE_DIRS}
+   )
+
+INCLUDE_DIRECTORIES(
     ${PROJECT_SOURCE_DIR}/tests/common/
    )