btrfs: remove redundant local variable in read_block_for_search
authorNikolay Borisov <nborisov@suse.com>
Wed, 27 May 2020 10:10:59 +0000 (13:10 +0300)
committerDavid Sterba <dsterba@suse.com>
Thu, 28 May 2020 12:01:52 +0000 (14:01 +0200)
The local 'b' variable is only used to directly read values from passed
extent buffer. So eliminate  it and directly use the input parameter.
Furthermore this shrinks the size of the following functions:

./scripts/bloat-o-meter ctree.orig fs/btrfs/ctree.o
add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-73 (-73)
Function                                     old     new   delta
read_block_for_search.isra                   876     871      -5
push_node_left                              1112    1044     -68
Total: Before=50348, After=50275, chg -0.14%

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ctree.c

index 5f94414..3a7648b 100644 (file)
@@ -2335,16 +2335,15 @@ read_block_for_search(struct btrfs_root *root, struct btrfs_path *p,
        struct btrfs_fs_info *fs_info = root->fs_info;
        u64 blocknr;
        u64 gen;
-       struct extent_buffer *b = *eb_ret;
        struct extent_buffer *tmp;
        struct btrfs_key first_key;
        int ret;
        int parent_level;
 
-       blocknr = btrfs_node_blockptr(b, slot);
-       gen = btrfs_node_ptr_generation(b, slot);
-       parent_level = btrfs_header_level(b);
-       btrfs_node_key_to_cpu(b, &first_key, slot);
+       blocknr = btrfs_node_blockptr(*eb_ret, slot);
+       gen = btrfs_node_ptr_generation(*eb_ret, slot);
+       parent_level = btrfs_header_level(*eb_ret);
+       btrfs_node_key_to_cpu(*eb_ret, &first_key, slot);
 
        tmp = find_extent_buffer(fs_info, blocknr);
        if (tmp) {