Also update the documentation of `Operation::fold`, which did not take into account in-place foldings.
Differential Revision: https://reviews.llvm.org/D155691
/// Attempt to fold this operation with the specified constant operand values
/// - the elements in "operands" will correspond directly to the operands of
- /// the operation, but may be null if non-constant. If folding is successful,
- /// this fills in the `results` vector. If not, `results` is unspecified.
+ /// the operation, but may be null if non-constant.
+ ///
+ /// If folding was successful, this function returns "success".
+ /// * If this operation was modified in-place (but not folded away),
+ /// `results` is empty.
+ /// * Otherwise, `results` is filled with the folded results.
+ /// If folding was unsuccessful, this function returns "failure".
LogicalResult fold(ArrayRef<Attribute> operands,
SmallVectorImpl<OpFoldResult> &results);
+ /// Attempt to fold this operation.
+ ///
+ /// If folding was successful, this function returns "success".
+ /// * If this operation was modified in-place (but not folded away),
+ /// `results` is empty.
+ /// * Otherwise, `results` is filled with the folded results.
+ /// If folding was unsuccessful, this function returns "failure".
+ LogicalResult fold(SmallVectorImpl<OpFoldResult> &results);
+
/// Returns true if the operation was registered with a particular trait, e.g.
/// hasTrait<OperandsAreSignlessIntegerLike>().
template <template <typename T> class Trait>
if (matchPattern(op, m_Constant()))
return cleanupFailure();
- // Check to see if any operands to the operation is constant and whether
- // the operation knows how to constant fold itself.
- SmallVector<Attribute, 4> constOperands(op->getNumOperands());
- for (unsigned i = 0, e = constOperands.size(); i != e; ++i)
- matchPattern(op->getOperand(i), m_Constant(&constOperands[i]));
-
// Try to fold the operation.
SmallVector<OpFoldResult, 4> foldResults;
- if (failed(op->fold(constOperands, foldResults)) || foldResults.empty())
+ if (failed(op->fold(foldResults)) || foldResults.empty())
return cleanupFailure();
// A temporary builder used for creating constants during folding.
return interface->fold(this, operands, results);
}
+LogicalResult Operation::fold(SmallVectorImpl<OpFoldResult> &results) {
+ // Check if any operands are constants.
+ SmallVector<Attribute> constants;
+ constants.assign(getNumOperands(), Attribute());
+ for (unsigned i = 0, e = getNumOperands(); i != e; ++i)
+ matchPattern(getOperand(i), m_Constant(&constants[i]));
+ return fold(constants, results);
+}
+
/// Emit an error with the op name prefixed, like "'dim' op " which is
/// convenient for verifiers.
InFlightDiagnostic Operation::emitOpError(const Twine &message) {
/// `results` with the results of the folding.
LogicalResult OperationFolder::tryToFold(Operation *op,
SmallVectorImpl<Value> &results) {
- SmallVector<Attribute, 8> operandConstants;
-
- // Check to see if any operands to the operation is constant and whether
- // the operation knows how to constant fold itself.
- operandConstants.assign(op->getNumOperands(), Attribute());
- for (unsigned i = 0, e = op->getNumOperands(); i != e; ++i)
- matchPattern(op->getOperand(i), m_Constant(&operandConstants[i]));
-
- // Attempt to constant fold the operation. If we failed, check to see if we at
- // least updated the operands of the operation. We treat this as an in-place
- // fold.
SmallVector<OpFoldResult, 8> foldResults;
- if (failed(op->fold(operandConstants, foldResults)) ||
+ if (failed(op->fold(foldResults)) ||
failed(processFoldResults(op, results, foldResults)))
return failure();
return success();