powerpc/pseries: replace kmalloc with kzalloc in PLPKS driver
authorNayna Jain <nayna@linux.ibm.com>
Sun, 6 Nov 2022 20:58:38 +0000 (15:58 -0500)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 24 Nov 2022 12:31:50 +0000 (23:31 +1100)
Replace kmalloc with kzalloc in construct_auth() function to default
initialize structure with zeroes.

Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221106205839.600442-6-nayna@linux.ibm.com
arch/powerpc/platforms/pseries/plpks.c

index 72d9deb..e8c0273 100644 (file)
@@ -162,19 +162,15 @@ static struct plpks_auth *construct_auth(u8 consumer)
        if (consumer > PKS_OS_OWNER)
                return ERR_PTR(-EINVAL);
 
-       auth = kmalloc(struct_size(auth, password, maxpwsize), GFP_KERNEL);
+       auth = kzalloc(struct_size(auth, password, maxpwsize), GFP_KERNEL);
        if (!auth)
                return ERR_PTR(-ENOMEM);
 
        auth->version = 1;
        auth->consumer = consumer;
-       auth->rsvd0 = 0;
-       auth->rsvd1 = 0;
 
-       if (consumer == PKS_FW_OWNER || consumer == PKS_BOOTLOADER_OWNER) {
-               auth->passwordlength = 0;
+       if (consumer == PKS_FW_OWNER || consumer == PKS_BOOTLOADER_OWNER)
                return auth;
-       }
 
        memcpy(auth->password, ospassword, ospasswordlength);