projects / platform / kernel / linux-starfive.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 06c14f5)
drm: bridge: cdns-mhdp8546: fix compile warning
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 29 Sep 2020 09:19:18 +0000 (12:19 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 1 Oct 2020 10:49:22 +0000 (12:49 +0200)
On x64 we get:

drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:751:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]

The registers are 32 bit, so fix by casting to u32.

Fixes: fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge")
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reviewed-by: Swapnil Jakhade <sjakhade@cadence.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200929091918.24813-1-tomi.valkeinen@ti.com
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c patch | blob | history

diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
index 621ebdb..d0c6561 100644 (file)
--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
@@ -748,7 +748,7 @@ static int cdns_mhdp_fw_activate(const struct firmware *fw,
         * bridge should already be detached.
         */
        if (mhdp->bridge_attached)
-               writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
+               writel(~(u32)CDNS_APB_INT_MASK_SW_EVENT_INT,
                       mhdp->regs + CDNS_APB_INT_MASK);
 
        spin_unlock(&mhdp->start_lock);
@@ -1689,7 +1689,7 @@ static int cdns_mhdp_attach(struct drm_bridge *bridge,
 
        /* Enable SW event interrupts */
        if (hw_ready)
-               writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
+               writel(~(u32)CDNS_APB_INT_MASK_SW_EVENT_INT,
                       mhdp->regs + CDNS_APB_INT_MASK);
 
        return 0;
@@ -2122,7 +2122,7 @@ static void cdns_mhdp_bridge_hpd_enable(struct drm_bridge *bridge)
 
        /* Enable SW event interrupts */
        if (mhdp->bridge_attached)
-               writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
+               writel(~(u32)CDNS_APB_INT_MASK_SW_EVENT_INT,
                       mhdp->regs + CDNS_APB_INT_MASK);
 }
 
Domain: System / Kernel;