media: vivid: fix an error code in vivid_create_instance()

Preserve the error code stored in "dev->kthread_cec" before setting it
to NULL.

Fixes: 439e520995ab ("media: vivid: add signal-free time for cec message xfer")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/test-drivers/vivid/vivid-core.c b/drivers/media/test-drivers/vivid/vivid-core.c
index bcf03bea1e3c1d11755bb07171181c6cefb9f19d..04b75666bad4d5a027fe25544e9b867fb670558e 100644 (file)
--- a/drivers/media/test-drivers/vivid/vivid-core.c
+++ b/drivers/media/test-drivers/vivid/vivid-core.c
@@ -1934,9 +1934,9 @@ static int vivid_create_instance(struct platform_device *pdev, int inst)
                dev->kthread_cec = kthread_run(vivid_cec_bus_thread, dev,
                                               "vivid_cec-%s", dev->v4l2_dev.name);
                if (IS_ERR(dev->kthread_cec)) {
+                       ret = PTR_ERR(dev->kthread_cec);
                        dev->kthread_cec = NULL;
                        v4l2_err(&dev->v4l2_dev, "kernel_thread() failed\n");
-                       ret = PTR_ERR(dev->kthread_cec);
                        goto unreg_dev;
                }
        }