clang-format: Fix crash on invalid code.
authorDaniel Jasper <djasper@google.com>
Mon, 19 Jan 2015 10:51:42 +0000 (10:51 +0000)
committerDaniel Jasper <djasper@google.com>
Mon, 19 Jan 2015 10:51:42 +0000 (10:51 +0000)
Input "a<," made clang-format crash.

llvm-svn: 226450

clang/lib/Format/FormatToken.cpp
clang/unittests/Format/FormatTest.cpp

index badb3a3..0addbfe 100644 (file)
@@ -59,7 +59,8 @@ void TokenRole::precomputeFormattingInfos(const FormatToken *Token) {}
 unsigned CommaSeparatedList::formatAfterToken(LineState &State,
                                               ContinuationIndenter *Indenter,
                                               bool DryRun) {
-  if (!State.NextToken->Previous || !State.NextToken->Previous->Previous)
+  if (State.NextToken == nullptr || !State.NextToken->Previous ||
+      !State.NextToken->Previous->Previous)
     return 0;
 
   // Ensure that we start on the opening brace.
index 1352615..548273a 100644 (file)
@@ -6038,6 +6038,8 @@ TEST_F(FormatTest, FormatsBracedListsInColumnLayout) {
   // No column layout should be used here.
   verifyFormat("aaaaaaaaaaaaaaa = {aaaaaaaaaaaaaaaaaaaaaaaaaaa, 0, 0,\n"
                "                   bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb};");
+
+  verifyNoCrash("a<,");
 }
 
 TEST_F(FormatTest, PullTrivialFunctionDefinitionsIntoSingleLine) {