gallium/aux/util/u_dump_defines.c: Fix -Wcompare-unsigned warning
authorGert Wollny <gw.fossdev@gmail.com>
Thu, 16 Nov 2017 15:09:37 +0000 (16:09 +0100)
committerBrian Paul <brianp@vmware.com>
Fri, 17 Nov 2017 16:27:56 +0000 (09:27 -0700)
u_bit_scan may return -1 that then may be interpreted as (unsigned)-1 in
the following comparison, since num_names is unsigned. Convert the latter to
be int as well.

Signed-off-by: Gert Wollny <gw.fossdev@gmail.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
src/gallium/auxiliary/util/u_dump_defines.c

index e431cd9..50dfa37 100644 (file)
@@ -99,7 +99,7 @@ util_dump_flags_continuous(FILE *stream, unsigned value, unsigned num_names,
 
    while (value) {
       int i = u_bit_scan(&value);
-      if (i >= num_names || !names[i])
+      if (i >= (int)num_names || !names[i])
          unknown |= 1u << i;
       if (!first)
          fputs("|", stream);