cxl: Unlock on error in probe

[ Upstream commit 58d876fa7181f2f393190c1d32c056b5a9d34aa2 ]

We should unlock if get_cxl_adapter() fails.

Fixes: 594ff7d067ca ("cxl: Support to flash a new image on the adapter from a guest")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c
index c63d61e..381a9a1 100644 (file)
--- a/drivers/misc/cxl/flash.c
+++ b/drivers/misc/cxl/flash.c
@@ -401,8 +401,10 @@ static int device_open(struct inode *inode, struct file *file)
        if (down_interruptible(&sem) != 0)
                return -EPERM;
 
-       if (!(adapter = get_cxl_adapter(adapter_num)))
-               return -ENODEV;
+       if (!(adapter = get_cxl_adapter(adapter_num))) {
+               rc = -ENODEV;
+               goto err_unlock;
+       }
 
        file->private_data = adapter;
        continue_token = 0;
@@ -446,6 +448,8 @@ err1:
                free_page((unsigned long) le);
 err:
        put_device(&adapter->dev);
+err_unlock:
+       up(&sem);
 
        return rc;
 }