xfs: remove unnecessary shifts
authorDarrick J. Wong <djwong@kernel.org>
Mon, 31 May 2021 18:31:56 +0000 (11:31 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Tue, 1 Jun 2021 19:53:59 +0000 (12:53 -0700)
The superblock verifier already validates that (1 << blocklog) ==
blocksize, so use the value directly instead of doing math.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
fs/xfs/xfs_bmap_util.c

index 0936f3a..997eb5c 100644 (file)
@@ -945,7 +945,7 @@ xfs_flush_unmap_range(
        xfs_off_t               rounding, start, end;
        int                     error;
 
-       rounding = max_t(xfs_off_t, 1 << mp->m_sb.sb_blocklog, PAGE_SIZE);
+       rounding = max_t(xfs_off_t, mp->m_sb.sb_blocksize, PAGE_SIZE);
        start = round_down(offset, rounding);
        end = round_up(offset + len, rounding) - 1;
 
@@ -1053,9 +1053,9 @@ xfs_prepare_shift(
         * extent (after split) during the shift and corrupt the file. Start
         * with the block just prior to the start to stabilize the boundary.
         */
-       offset = round_down(offset, 1 << mp->m_sb.sb_blocklog);
+       offset = round_down(offset, mp->m_sb.sb_blocksize);
        if (offset)
-               offset -= (1 << mp->m_sb.sb_blocklog);
+               offset -= mp->m_sb.sb_blocksize;
 
        /*
         * Writeback and invalidate cache for the remainder of the file as we're