zd1211rw: Replace spin_is_locked() with lockdep
authorLance Roy <ldr709@gmail.com>
Wed, 3 Oct 2018 05:38:54 +0000 (22:38 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 5 Oct 2018 08:35:05 +0000 (11:35 +0300)
lockdep_assert_held() is better suited to checking locking requirements,
since it won't get confused when someone else holds the lock. This is
also a step towards possibly removing spin_is_locked().

Signed-off-by: Lance Roy <ldr709@gmail.com>
Cc: Daniel Drake <dsd@gentoo.org>
Cc: Ulrich Kunitz <kune@deine-taler.de>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: <linux-wireless@vger.kernel.org>
Cc: <netdev@vger.kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/zydas/zd1211rw/zd_mac.c

index 1f6d9f357e57de8d733e86de73ac90b64cf3ffd5..9ccd780695f0a6cb8a1eec04ffcc351942d0130e 100644 (file)
@@ -235,7 +235,7 @@ void zd_mac_clear(struct zd_mac *mac)
 {
        flush_workqueue(zd_workqueue);
        zd_chip_clear(&mac->chip);
-       ZD_ASSERT(!spin_is_locked(&mac->lock));
+       lockdep_assert_held(&mac->lock);
        ZD_MEMCLEAR(mac, sizeof(struct zd_mac));
 }