Revert 6654719 "[CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply...
authorHans Wennborg <hans@chromium.org>
Wed, 29 Apr 2020 13:12:43 +0000 (15:12 +0200)
committerHans Wennborg <hans@chromium.org>
Wed, 29 Apr 2020 13:12:43 +0000 (15:12 +0200)
It broke building libclang.dll in Windows builds configured with
LLVM_ENABLE_PIC=OFF. See discussion on the cfe-commits thread.

clang/tools/libclang/CMakeLists.txt

index 9368501..bb2b14c 100644 (file)
@@ -77,7 +77,7 @@ if(MSVC)
   set(LLVM_EXPORTED_SYMBOL_FILE)
 endif()
 
-if(LLVM_ENABLE_PIC)
+if(LLVM_ENABLE_PIC OR NOT LIBCLANG_BUILD_STATIC)
   set(ENABLE_SHARED SHARED)
 endif()