projects
/
sdk
/
emulator
/
qemu.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7fa2c46
)
qdev: Check if unplug handler exists before calling it
author
Amit Shah
<amit.shah@redhat.com>
Mon, 2 Nov 2009 09:26:41 +0000
(14:56 +0530)
committer
Anthony Liguori
<aliguori@us.ibm.com>
Thu, 12 Nov 2009 17:23:54 +0000
(11:23 -0600)
A bus may have hotplugging enabled but not have the 'unplug'
callback defined, which would lead to a crash on trying to
unplug a device on the bus.
Fix by introducing an assert to check if the callback is valid.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
hw/qdev.c
patch
|
blob
|
history
diff --git
a/hw/qdev.c
b/hw/qdev.c
index
c7884d0
..
d19d531
100644
(file)
--- a/
hw/qdev.c
+++ b/
hw/qdev.c
@@
-258,6
+258,8
@@
int qdev_unplug(DeviceState *dev)
dev->parent_bus->name);
return -1;
}
+ assert(dev->info->unplug != NULL);
+
return dev->info->unplug(dev);
}