misc: bcm-vk: use list_move_tail instead of list_del/list_add_tail in bcm_vk_msg.c
authorBaokun Li <libaokun1@huawei.com>
Wed, 9 Jun 2021 07:14:30 +0000 (15:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jun 2021 12:52:16 +0000 (14:52 +0200)
Using list_move_tail() instead of list_del() + list_add_tail() in bcm_vk_msg.c.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Link: https://lore.kernel.org/r/20210609071430.1337400-1-libaokun1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/bcm-vk/bcm_vk_msg.c

index 6efc52b..066b9ef 100644 (file)
@@ -354,8 +354,7 @@ static void bcm_vk_drain_all_pend(struct device *dev,
        for (num = 0; num < chan->q_nr; num++) {
                list_for_each_entry_safe(entry, tmp, &chan->pendq[num], node) {
                        if ((!ctx) || (entry->ctx->idx == ctx->idx)) {
-                               list_del(&entry->node);
-                               list_add_tail(&entry->node, &del_q);
+                               list_move_tail(&entry->node, &del_q);
                        }
                }
        }