octeontx2-af: Update correct mask to filter IPv4 fragments
authorSuman Ghosh <sumang@marvell.com>
Wed, 3 May 2023 07:09:39 +0000 (12:39 +0530)
committerDavid S. Miller <davem@davemloft.net>
Wed, 3 May 2023 08:02:59 +0000 (09:02 +0100)
During the initial design, the IPv4 ip_flag mask was set to 0xff.
Which results to filter only fragmets with (fragment_offset == 0).
As part of the fix, updated the mask to 0x20 to filter all the
fragmented packets irrespective of the fragment_offset value.

Fixes: c672e3727989 ("octeontx2-pf: Add support to filter packet based on IP fragment")
Signed-off-by: Suman Ghosh <sumang@marvell.com>
Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c

index 044cc21..8392f63 100644 (file)
@@ -544,7 +544,7 @@ static int otx2_tc_prepare_flow(struct otx2_nic *nic, struct otx2_tc_flow *node,
                if (match.mask->flags & FLOW_DIS_IS_FRAGMENT) {
                        if (ntohs(flow_spec->etype) == ETH_P_IP) {
                                flow_spec->ip_flag = IPV4_FLAG_MORE;
-                               flow_mask->ip_flag = 0xff;
+                               flow_mask->ip_flag = IPV4_FLAG_MORE;
                                req->features |= BIT_ULL(NPC_IPFRAG_IPV4);
                        } else if (ntohs(flow_spec->etype) == ETH_P_IPV6) {
                                flow_spec->next_header = IPPROTO_FRAGMENT;