video: Use bool instead int pointer for get_opt_bool() argument
authorDaniel Wagner <daniel.wagner@bmw-carit.de>
Tue, 9 Feb 2016 09:18:32 +0000 (10:18 +0100)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 16 Feb 2016 13:09:20 +0000 (15:09 +0200)
As the function name already indicates that get_opt_bool() parses
for a bool. It is not a surprise that compiler is complaining
about it when -Werror=incompatible-pointer-types is used:

drivers/video/fbdev/intelfb/intelfbdrv.c: In function ‘intelfb_setup’:
drivers/video/fbdev/intelfb/intelfbdrv.c:353:39: error: passing argument 3 of ‘get_opt_bool’ from incompatible pointer type [-Werror=incompatible-pointer-types]
   if (get_opt_bool(this_opt, "accel", &accel))

Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/intelfb/intelfbdrv.c

index bbec737..bf20744 100644 (file)
@@ -302,7 +302,7 @@ static __inline__ int get_opt_int(const char *this_opt, const char *name,
 }
 
 static __inline__ int get_opt_bool(const char *this_opt, const char *name,
-                                  int *ret)
+                                  bool *ret)
 {
        if (!ret)
                return 0;