hmp: Compile hmp_info_spice() only with CONFIG_SPICE
authorMarkus Armbruster <armbru@redhat.com>
Tue, 13 Jan 2015 14:46:39 +0000 (15:46 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 29 Jan 2015 09:01:45 +0000 (10:01 +0100)
It's dead code when CONFIG_SPICE is off.  If it wasn't, it would crash
dereferencing the null pointer returned by the qmp_query_spice()
dummy in qmp.c.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
hmp.c

diff --git a/hmp.c b/hmp.c
index 481be80..a42c5c0 100644 (file)
--- a/hmp.c
+++ b/hmp.c
@@ -535,6 +535,7 @@ out:
     qapi_free_VncInfo(info);
 }
 
+#ifdef CONFIG_SPICE
 void hmp_info_spice(Monitor *mon, const QDict *qdict)
 {
     SpiceChannelList *chan;
@@ -581,6 +582,7 @@ void hmp_info_spice(Monitor *mon, const QDict *qdict)
 out:
     qapi_free_SpiceInfo(info);
 }
+#endif
 
 void hmp_info_balloon(Monitor *mon, const QDict *qdict)
 {