Input: cros_ec_keyb - drop unnecessary call to dev_set_drvdata and other changes
authorGuenter Roeck <linux@roeck-us.net>
Wed, 18 Jan 2017 18:37:49 +0000 (10:37 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 18 Jan 2017 19:33:00 +0000 (11:33 -0800)
There is no call to platform_get_drvdata() or dev_get_drvdata().
Drop the unnecessary call to dev_set_drvdata().
Other relevant changes:
  Use existing variable 'dev' instead of dereferencing it several times

This conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches

- Drop dev_set_drvdata()
- Use local variable 'struct device *dev' consistently

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/cros_ec_keyb.c

index 4b0878f3547171044600bd85d9a0c24c66accd3a..165c722408aaa37128e9e56ebf88674b0e0ea4f2 100644 (file)
@@ -242,7 +242,7 @@ static int cros_ec_keyb_probe(struct platform_device *pdev)
        struct device_node *np;
        int err;
 
-       np = pdev->dev.of_node;
+       np = dev->of_node;
        if (!np)
                return -ENODEV;
 
@@ -272,7 +272,6 @@ static int cros_ec_keyb_probe(struct platform_device *pdev)
 
        ckdev->ec = ec;
        ckdev->dev = dev;
-       dev_set_drvdata(dev, ckdev);
 
        idev->name = CROS_EC_DEV_NAME;
        idev->phys = ec->phys_name;