projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b6829c7
)
bnx2fc: fix an error code in _bnx2fc_create()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Tue, 4 Nov 2014 10:37:59 +0000
(13:37 +0300)
committer
Christoph Hellwig
<hch@lst.de>
Wed, 12 Nov 2014 11:05:25 +0000
(12:05 +0100)
We should be returning an error code here instead of success. Either
-ENODEV or -ENOMEM would work. There is also a failure message in
printk().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Chad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/bnx2fc/bnx2fc_fcoe.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index
b0d7256
..
2262c75
100644
(file)
--- a/
drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/
drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@
-2195,6
+2195,7
@@
static int _bnx2fc_create(struct net_device *netdev,
interface = bnx2fc_interface_create(hba, netdev, fip_mode);
if (!interface) {
printk(KERN_ERR PFX "bnx2fc_interface_create failed\n");
+ rc = -ENOMEM;
goto ifput_err;
}