lp8727_charger: Clean up lp8727_charger_changed()
authorKim, Milo <Milo.Kim@ti.com>
Fri, 31 Aug 2012 09:26:22 +0000 (09:26 +0000)
committerAnton Vorontsov <anton.vorontsov@linaro.org>
Fri, 21 Sep 2012 01:06:13 +0000 (18:06 -0700)
Declare a variable at one line. Just return when no charger exists to make
code simpler.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
drivers/power/lp8727_charger.c

index 13a787a..19c21f9 100644 (file)
@@ -393,16 +393,20 @@ static int lp8727_battery_get_property(struct power_supply *psy,
 static void lp8727_charger_changed(struct power_supply *psy)
 {
        struct lp8727_chg *pchg = dev_get_drvdata(psy->dev->parent);
+       u8 eoc_level;
+       u8 ichg;
        u8 val;
-       u8 eoc_level, ichg;
-
-       if (lp8727_is_charger_attached(psy->name, pchg->devid)) {
-               if (pchg->chg_parm) {
-                       eoc_level = pchg->chg_parm->eoc_level;
-                       ichg = pchg->chg_parm->ichg;
-                       val = (ichg << LP8727_ICHG_SHIFT) | eoc_level;
-                       lp8727_write_byte(pchg, LP8727_CHGCTRL2, val);
-               }
+
+       /* skip if no charger exists */
+       if (!lp8727_is_charger_attached(psy->name, pchg->devid))
+               return;
+
+       /* update charging parameters */
+       if (pchg->chg_parm) {
+               eoc_level = pchg->chg_parm->eoc_level;
+               ichg = pchg->chg_parm->ichg;
+               val = (ichg << LP8727_ICHG_SHIFT) | eoc_level;
+               lp8727_write_byte(pchg, LP8727_CHGCTRL2, val);
        }
 }