media: coda: jpeg: add NULL check after kmalloc
authorChen Zhou <chenzhou10@huawei.com>
Sat, 9 May 2020 02:07:11 +0000 (04:07 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sat, 4 Jul 2020 09:56:37 +0000 (11:56 +0200)
Fixes coccicheck warning:

./drivers/media/platform/coda/coda-jpeg.c:331:3-31:
alloc with no test, possible model on line 354

Add NULL check after kmalloc.

Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/coda/coda-jpeg.c

index 00d1985..b11cfbe 100644 (file)
@@ -327,8 +327,11 @@ int coda_jpeg_decode_header(struct coda_ctx *ctx, struct vb2_buffer *vb)
                                 "only 8-bit quantization tables supported\n");
                        continue;
                }
-               if (!ctx->params.jpeg_qmat_tab[i])
+               if (!ctx->params.jpeg_qmat_tab[i]) {
                        ctx->params.jpeg_qmat_tab[i] = kmalloc(64, GFP_KERNEL);
+                       if (!ctx->params.jpeg_qmat_tab[i])
+                               return -ENOMEM;
+               }
                memcpy(ctx->params.jpeg_qmat_tab[i],
                       quantization_tables[i].start, 64);
        }