SUNRPC: Re-order construction of the first reply fields
authorChuck Lever <chuck.lever@oracle.com>
Mon, 2 Jan 2023 17:07:39 +0000 (12:07 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 20 Feb 2023 14:20:19 +0000 (09:20 -0500)
Clean up: Group these together for legibility.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
net/sunrpc/svc.c

index acac00b..910250a 100644 (file)
@@ -1248,19 +1248,15 @@ svc_process_common(struct svc_rqst *rqstp, struct kvec *argv, struct kvec *resv)
        set_bit(RQ_USEDEFERRAL, &rqstp->rq_flags);
        clear_bit(RQ_DROPME, &rqstp->rq_flags);
 
+       /* Construct the first words of the reply: */
        svc_putu32(resv, rqstp->rq_xid);
+       svc_putnl(resv, RPC_REPLY);
+       reply_statp = resv->iov_base + resv->iov_len;
 
        vers = svc_getnl(argv);
-
-       /* First words of reply: */
-       svc_putnl(resv, 1);             /* REPLY */
-
        if (vers != 2)          /* RPC version number */
                goto err_bad_rpc;
 
-       /* Save position in case we later decide to reject: */
-       reply_statp = resv->iov_base + resv->iov_len;
-
        svc_putnl(resv, 0);             /* ACCEPT */
 
        rqstp->rq_prog = prog = svc_getnl(argv);        /* program number */